• Oscar Salvador's avatar
    mm,page_owner: fix printing of stack records · 74017458
    Oscar Salvador authored
    When seq_* code sees that its buffer overflowed, it re-allocates a bigger
    onecand calls seq_operations->start() callback again.  stack_start()
    naively though that if it got called again, it meant that the old record
    got already printed so it returned the next object, but that is not true.
    
    The consequence of that is that every time stack_stop() -> stack_start()
    get called because we needed a bigger buffer, stack_start() will skip
    entries, and those will not be printed.
    
    Fix it by not advancing to the next object in stack_start().
    
    Link: https://lkml.kernel.org/r/20240404070702.2744-5-osalvador@suse.de
    Fixes: 765973a0 ("mm,page_owner: display all stacks and their count")
    Signed-off-by: default avatarOscar Salvador <osalvador@suse.de>
    Reviewed-by: default avatarVlastimil Babka <vbabka@suse.cz>
    Cc: Alexander Potapenko <glider@google.com>
    Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
    Cc: Andrey Konovalov <andreyknvl@gmail.com>
    Cc: Marco Elver <elver@google.com>
    Cc: Michal Hocko <mhocko@suse.com>
    Cc: Palmer Dabbelt <palmer@dabbelt.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    74017458
page_owner.c 24.5 KB