• Guenter Roeck's avatar
    hwmon: (peci/dimmtemp) Use HWMON_CHANNEL_INFO macro · 7c399d6a
    Guenter Roeck authored
    The HWMON_CHANNEL_INFO macro simplifies the code, reduces the likelihood
    of errors, and makes the code easier to read.
    
    The conversion was done automatically with coccinelle. The semantic patch
    used to make this change is as follows.
    
    @s@
    identifier i,j,ty;
    @@
    
    -struct hwmon_channel_info j = {
    -       .type = ty,
    -       .config = i,
    -};
    
    @r@
    initializer list elements;
    identifier s.i;
    @@
    
    -u32 i[] = {
    -  elements,
    -  0
    -};
    
    @script:ocaml t@
    ty << s.ty;
    elements << r.elements;
    shorter;
    elems;
    @@
    
    shorter :=
       make_ident (List.hd(List.rev (Str.split (Str.regexp "_") ty)));
    elems :=
       make_ident
        (String.concat ","
         (List.map (fun x -> Printf.sprintf "\n\t\t\t   %s" x)
           (Str.split (Str.regexp " , ") elements)))
    
    @@
    identifier s.j,t.shorter;
    identifier t.elems;
    @@
    
    - &j
    + HWMON_CHANNEL_INFO(shorter,elems)
    
    This patch does not introduce functional changes. Many thanks to
    Julia Lawall for providing the coccinelle script.
    
    Cc: Iwona Winiarska <iwona.winiarska@intel.com>
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    7c399d6a
dimmtemp.c 16.2 KB