• Namhyung Kim's avatar
    perf annotate-data: Do not delete non-asm lines · 879ebf3c
    Namhyung Kim authored
    For data type profiling, it removed non-instruction lines from the list
    of annotation lines.  It was to simplify the implementation dealing with
    instructions like to calculate the PC-relative address and to search the
    shortest path to the target instruction or basic block.
    
    But it means that it removes all the comments and debug information in
    the annotate output like source file name and line numbers.  To support
    both code annotation and data type annotation, it'd be better to keep
    the non-instruction lines as well.
    
    So this change is to skip those lines during the data type profiling
    and to display them in the normal perf annotate output.
    
    No function changes intended (other than having more lines).
    Reviewed-by: default avatarIan Rogers <irogers@google.com>
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://lore.kernel.org/r/20240405211800.1412920-4-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    879ebf3c
annotate.c 65.2 KB