• Eric Biggers's avatar
    fscrypt: support crypto data unit size less than filesystem block size · 5b118884
    Eric Biggers authored
    Until now, fscrypt has always used the filesystem block size as the
    granularity of file contents encryption.  Two scenarios have come up
    where a sub-block granularity of contents encryption would be useful:
    
    1. Inline crypto hardware that only supports a crypto data unit size
       that is less than the filesystem block size.
    
    2. Support for direct I/O at a granularity less than the filesystem
       block size, for example at the block device's logical block size in
       order to match the traditional direct I/O alignment requirement.
    
    (1) first came up with older eMMC inline crypto hardware that only
    supports a crypto data unit size of 512 bytes.  That specific case
    ultimately went away because all systems with that hardware continued
    using out of tree code and never actually upgraded to the upstream
    inline crypto framework.  But, now it's coming back in a new way: some
    current UFS controllers only support a data unit size of 4096 bytes, and
    there is a proposal to increase the filesystem block size to 16K.
    
    (2) was discussed as a "nice to have" feature, though not essential,
    when support for direct I/O on encrypted files was being upstreamed.
    
    Still, the fact that this feature has come up several times does suggest
    it would be wise to have available.  Therefore, this patch implements it
    by using one of the reserved bytes in fscrypt_policy_v2 to allow users
    to select a sub-block data unit size.  Supported data unit sizes are
    powers of 2 between 512 and the filesystem block size, inclusively.
    Support is implemented for both the FS-layer and inline crypto cases.
    
    This patch focuses on the basic support for sub-block data units.  Some
    things are out of scope for this patch but may be addressed later:
    
    - Supporting sub-block data units in combination with
      FSCRYPT_POLICY_FLAG_IV_INO_LBLK_64, in most cases.  Unfortunately this
      combination usually causes data unit indices to exceed 32 bits, and
      thus fscrypt_supported_policy() correctly disallows it.  The users who
      potentially need this combination are using f2fs.  To support it, f2fs
      would need to provide an option to slightly reduce its max file size.
    
    - Supporting sub-block data units in combination with
      FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32.  This has the same problem
      described above, but also it will need special code to make DUN
      wraparound still happen on a FS block boundary.
    
    - Supporting use case (2) mentioned above.  The encrypted direct I/O
      code will need to stop requiring and assuming FS block alignment.
      This won't be hard, but it belongs in a separate patch.
    
    - Supporting this feature on filesystems other than ext4 and f2fs.
      (Filesystems declare support for it via their fscrypt_operations.)
      On UBIFS, sub-block data units don't make sense because UBIFS encrypts
      variable-length blocks as a result of compression.  CephFS could
      support it, but a bit more work would be needed to make the
      fscrypt_*_block_inplace functions play nicely with sub-block data
      units.  I don't think there's a use case for this on CephFS anyway.
    
    Link: https://lore.kernel.org/r/20230925055451.59499-6-ebiggers@kernel.orgSigned-off-by: default avatarEric Biggers <ebiggers@google.com>
    5b118884
crypto.c 5.98 KB