• Namhyung Kim's avatar
    perf report: Hide tip message when -q option is given · 8b53dbef
    Namhyung Kim authored
    The tip message at the end was printed regardless of the -q option.
    
    Originally, the message suggested only '-s comm,dso' option for higher
    level view when no sort option and parent option were given.
    
    Now it shows random help message regardless of the options so the
    condition can be simplified to honor the -q option.
    
    Committer notes:
    
    Before:
    
      $ perf report --stdio -q
        42.77%  ls       ls                [.] _init
        13.21%  ls       ld-2.24.so        [.] match_symbol
        12.55%  ls       libc-2.24.so      [.] __strcoll_l
        11.94%  ls       libc-2.24.so      [.] _init
    
      #
      # (Tip: Show current config key-value pairs: perf config --list)
      #
      $
    
    After:
    
      $ perf report --stdio -q
        42.77%  ls       ls                [.] _init
        13.21%  ls       ld-2.24.so        [.] match_symbol
        12.55%  ls       libc-2.24.so      [.] __strcoll_l
        11.94%  ls       libc-2.24.so      [.] _init
    
      $
    
    We still have those two extra lines tho (that git commit insists in
    turning into one, or git commit --amend doesn't make me add), food for
    another patch...
    Reported-and-Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: kernel-team@lge.com
    Link: http://lkml.kernel.org/r/20170307150851.22304-2-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    8b53dbef
builtin-report.c 30.1 KB