• Michal Hocko's avatar
    bcachefs: do not use PF_MEMALLOC_NORECLAIM · 9897713f
    Michal Hocko authored
    Patch series "remove PF_MEMALLOC_NORECLAIM" v3.
    
    
    This patch (of 2):
    
    bch2_new_inode relies on PF_MEMALLOC_NORECLAIM to try to allocate a new
    inode to achieve GFP_NOWAIT semantic while holding locks. If this
    allocation fails it will drop locks and use GFP_NOFS allocation context.
    
    We would like to drop PF_MEMALLOC_NORECLAIM because it is really
    dangerous to use if the caller doesn't control the full call chain with
    this flag set. E.g. if any of the function down the chain needed
    GFP_NOFAIL request the PF_MEMALLOC_NORECLAIM would override this and
    cause unexpected failure.
    
    While this is not the case in this particular case using the scoped gfp
    semantic is not really needed bacause we can easily pus the allocation
    context down the chain without too much clutter.
    
    [akpm@linux-foundation.org: fix kerneldoc warnings]
    Link: https://lkml.kernel.org/r/20240926172940.167084-1-mhocko@kernel.org
    Link: https://lkml.kernel.org/r/20240926172940.167084-2-mhocko@kernel.orgSigned-off-by: default avatarMichal Hocko <mhocko@suse.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
    Reviewed-by: Jan Kara <jack@suse.cz> # For vfs changes
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Christian Brauner <brauner@kernel.org>
    Cc: James Morris <jmorris@namei.org>
    Cc: Kent Overstreet <kent.overstreet@linux.dev>
    Cc: Paul Moore <paul@paul-moore.com>
    Cc: Serge E. Hallyn <serge@hallyn.com>
    Cc: Yafang Shao <laoar.shao@gmail.com>
    Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    9897713f
security.h 62.4 KB