• Steven Rostedt (VMware)'s avatar
    tracing: Use trace_clock_local() for looping in preemptirq_delay_test.c · 12ad0cb2
    Steven Rostedt (VMware) authored
    The preemptirq_delay_test module is used for the ftrace selftest code that
    tests the latency tracers. The problem is that it uses ktime for the delay
    loop, and then checks the tracer to see if the delay loop is caught, but the
    tracer uses trace_clock_local() which uses various different other clocks to
    measure the latency. As ktime uses the clock cycles, and the code then
    converts that to nanoseconds, it causes rounding errors, and the preemptirq
    latency tests are failing due to being off by 1 (it expects to see a delay
    of 500000 us, but the delay is only 499999 us). This is happening due to a
    rounding error in the ktime (which is totally legit). The purpose of the
    test is to see if it can catch the delay, not to test the accuracy between
    trace_clock_local() and ktime_get(). Best to use apples to apples, and have
    the delay loop use the same clock as the latency tracer does.
    
    Cc: stable@vger.kernel.org
    Fixes: f96e8577 ("lib: Add module for testing preemptoff/irqsoff latency tracers")
    Acked-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
    Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
    12ad0cb2
preemptirq_delay_test.c 1.63 KB