• Zi Shen Lim's avatar
    arm64: bpf: jit JMP_JSET_{X,K} · 9f3c9bea
    Zi Shen Lim authored
    commit 98397fc5 upstream.
    
    Original implementation commit e54bcde3 ("arm64: eBPF JIT compiler")
    had the relevant code paths, but due to an oversight always fail jiting.
    
    As a result, we had been falling back to BPF interpreter whenever a BPF
    program has JMP_JSET_{X,K} instructions.
    
    With this fix, we confirm that the corresponding tests in lib/test_bpf
    continue to pass, and also jited.
    
    ...
    [    2.784553] test_bpf: #30 JSET jited:1 188 192 197 PASS
    [    2.791373] test_bpf: #31 tcpdump port 22 jited:1 325 677 625 PASS
    [    2.808800] test_bpf: #32 tcpdump complex jited:1 323 731 991 PASS
    ...
    [    3.190759] test_bpf: #237 JMP_JSET_K: if (0x3 & 0x2) return 1 jited:1 110 PASS
    [    3.192524] test_bpf: #238 JMP_JSET_K: if (0x3 & 0xffffffff) return 1 jited:1 98 PASS
    [    3.211014] test_bpf: #249 JMP_JSET_X: if (0x3 & 0x2) return 1 jited:1 120 PASS
    [    3.212973] test_bpf: #250 JMP_JSET_X: if (0x3 & 0xffffffff) return 1 jited:1 89 PASS
    ...
    
    Fixes: e54bcde3 ("arm64: eBPF JIT compiler")
    Signed-off-by: default avatarZi Shen Lim <zlim.lnx@gmail.com>
    Acked-by: default avatarWill Deacon <will.deacon@arm.com>
    Acked-by: default avatarYang Shi <yang.shi@linaro.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
    9f3c9bea
bpf_jit_comp.c 19.3 KB