• Fabio M. De Francesco's avatar
    drm/amd/amdgpu: Replace kmap() with kmap_local_page() · a2c55426
    Fabio M. De Francesco authored
    
    
    kmap() is being deprecated in favor of kmap_local_page().
    
    There are two main problems with kmap(): (1) It comes with an overhead as
    mapping space is restricted and protected by a global lock for
    synchronization and (2) it also requires global TLB invalidation when the
    kmap’s pool wraps and it might block when the mapping space is fully
    utilized until a slot becomes available.
    
    With kmap_local_page() the mappings are per thread, CPU local, can take
    page faults, and can be called from any context (including interrupts).
    It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore,
    the tasks can be preempted and, when they are scheduled to run again, the
    kernel virtual addresses are restored and are still valid.
    
    Since its use in amdgpu/amdgpu_ttm.c is safe, it should be preferred.
    
    Therefore, replace kmap() with kmap_local_page() in amdgpu/amdgpu_ttm.c.
    Suggested-by: default avatarIra Weiny <ira.weiny@intel.com>
    Acked-by: default avatarChristian König <christian.koenig@amd.com>
    Signed-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    a2c55426
amdgpu_ttm.c 62.3 KB