• Hans de Goede's avatar
    platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type() · a2ed70d0
    Hans de Goede authored
    acpi_video_set_dmi_backlight_type() is troublesome because it may end up
    getting called after other backlight drivers have already called
    acpi_video_get_backlight_type() resulting in the other drivers
    already being registered even though they should not.
    
    In case of the acpi_video backlight, acpi_video_set_dmi_backlight_type()
    actually calls acpi_video_unregister_backlight() since that is often
    probed earlier, leading to userspace seeing the acpi_video0 class
    device being briefly available, leading to races in userspace where
    udev probe-rules try to access the device and it is already gone.
    
    In case of toshiba_acpi there are no DMI quirks to move to
    acpi/video_detect.c, but it also (ab)uses it for transflective
    displays. Adding transflective display support to video_detect.c would
    be quite involved. But luckily there are only 2 known models with
    a transflective display, so we can just add DMI quirks for those.
    Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    a2ed70d0
video_detect.c 18.2 KB