• Rob Herring's avatar
    arm64: dts: rockchip: Fix PCI node addresses on rk3399-gru · c13c823a
    Rob Herring authored
    The rk3399-gru PCI node addresses are wrong.
    
    In rk3399-gru-scarlet, the bus number in the address should be 0. This is
    because bus number assignment is dynamic and not known up front. For FDT,
    the bus number is simply ignored.
    
    In rk3399-gru-chromebook, the addresses are simply invalid. The first
    "reg" entry must be the configuration space for the device. The entry
    should be all 0s except for device/slot and function numbers. The existing
    64-bit memory space (0x83000000) entries are not valid because they must
    have the BAR address in the lower byte of the first cell.
    
    Warnings for these are enabled by adding the missing 'device_type = "pci"'
    for the root port node.
    Signed-off-by: default avatarRob Herring <robh@kernel.org>
    Link: https://lore.kernel.org/r/20231130191830.2424361-1-robh@kernel.orgSigned-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
    c13c823a
rk3399-gru-chromebook.dtsi 11.2 KB