• Brian Foster's avatar
    fs/remap_range: avoid spurious writeback on zero length request · a79168a0
    Brian Foster authored
    generic_remap_checks() can reduce the effective request length (i.e.,
    after the reflink extend to EOF case is handled) down to zero. If this
    occurs, __generic_remap_file_range_prep() proceeds through dio
    serialization, file mapping flush calls, and may invoke file_modified()
    before returning back to the filesystem caller, all of which immediately
    check for len == 0 and return.
    
    While this is mostly harmless, it is spurious and not completely
    without side effect. A filemap write call can submit I/O (but not
    wait on it) when the specified end byte precedes the start but
    happens to land on the same aligned page boundary, which can occur
    from __generic_remap_file_range_prep() when len is 0.
    
    The dedupe path already has a len == 0 check to break out before
    doing range comparisons. Lift this check a bit earlier in the
    function to cover the general case of len == 0 and avoid the
    unnecessary work. While here, account for the case where
    generic_remap_check_len() may also reduce length to zero.
    Signed-off-by: default avatarBrian Foster <bfoster@redhat.com>
    Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    a79168a0
remap_range.c 14.1 KB