• Satyam Sharma's avatar
    Netpoll leak · acad36f9
    Satyam Sharma authored
    [NETPOLL]: Fix a leak-n-bug in netpoll_cleanup()
    
    93ec2c72 applied excessive duct tape to
    the netpoll beast's netpoll_cleanup(), thus substituting one leak with
    another, and opening up a little buglet :-)
    
    net_device->npinfo (netpoll_info) is a shared and refcounted object and
    cannot simply be set NULL the first time netpoll_cleanup() is called.
    Otherwise, further netpoll_cleanup()'s see np->dev->npinfo == NULL and
    become no-ops, thus leaking. And it's a bug too: the first call to
    netpoll_cleanup() would thus (annoyingly) "disable" other (still alive)
    netpolls too. Maybe nobody noticed this because netconsole (only user
    of netpoll) never supported multiple netpoll objects earlier.
    
    This is a trivial and obvious one-line fixlet.
    Signed-off-by: default avatarSatyam Sharma <ssatyam@cse.iitk.ac.in>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    acad36f9
netpoll.c 18.8 KB