• Brett Creeley's avatar
    ionic: Don't send reset commands if FW isn't running · b8fd0271
    Brett Creeley authored
    It's possible the FW is already shutting down while the driver is being
    removed and/or when the driver is going through reset. This can cause
    unexpected/unnecessary errors to be printed:
    
    eth0: DEV_CMD IONIC_CMD_PORT_RESET (12) error, IONIC_RC_ERROR (29) failed
    eth1: DEV_CMD IONIC_CMD_RESET (3) error, IONIC_RC_ERROR (29) failed
    
    Fix this by checking the FW status register before issuing the reset
    commands.
    
    Also, since err may not be assigned in ionic_port_reset(), assign it a
    default value of 0, and remove an unnecessary log message.
    
    Fixes: fbfb8031 ("ionic: Add hardware init and device commands")
    Signed-off-by: default avatarBrett Creeley <brett@pensando.io>
    Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b8fd0271
ionic_dev.c 17.9 KB