• Oleg Nesterov's avatar
    signal, x86: Delay calling signals in atomic on RT enabled kernels · bf9ad37d
    Oleg Nesterov authored
    On x86_64 we must disable preemption before we enable interrupts
    for stack faults, int3 and debugging, because the current task is using
    a per CPU debug stack defined by the IST. If we schedule out, another task
    can come in and use the same stack and cause the stack to be corrupted
    and crash the kernel on return.
    
    When CONFIG_PREEMPT_RT is enabled, spinlock_t locks become sleeping, and
    one of these is the spin lock used in signal handling.
    
    Some of the debug code (int3) causes do_trap() to send a signal.
    This function calls a spinlock_t lock that has been converted to a
    sleeping lock. If this happens, the above issues with the corrupted
    stack is possible.
    
    Instead of calling the signal right away, for PREEMPT_RT and x86,
    the signal information is stored on the stacks task_struct and
    TIF_NOTIFY_RESUME is set. Then on exit of the trap, the signal resume
    code will send the signal when preemption is enabled.
    
    [ rostedt: Switched from #ifdef CONFIG_PREEMPT_RT to
      ARCH_RT_DELAYS_SIGNAL_SEND and added comments to the code. ]
    [bigeasy: Add on 32bit as per Yang Shi, minor rewording. ]
    [ tglx: Use a config option ]
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/r/Ygq5aBB/qMQw6aP5@linutronix.de
    bf9ad37d
Kconfig.preempt 5.14 KB