• Mauricio Faria de Oliveira's avatar
    modpost: add missing else to the "of" check · cbc3d00c
    Mauricio Faria de Oliveira authored
    Without this 'else' statement, an "usb" name goes into two handlers:
    the first/previous 'if' statement _AND_ the for-loop over 'devtable',
    but the latter is useless as it has no 'usb' device_id entry anyway.
    
    Tested with allmodconfig before/after patch; no changes to *.mod.c:
    
        git checkout v6.6-rc3
        make -j$(nproc) allmodconfig
        make -j$(nproc) olddefconfig
    
        make -j$(nproc)
        find . -name '*.mod.c' | cpio -pd /tmp/before
    
        # apply patch
    
        make -j$(nproc)
        find . -name '*.mod.c' | cpio -pd /tmp/after
    
        diff -r /tmp/before/ /tmp/after/
        # no difference
    
    Fixes: acbef7b7 ("modpost: fix module autoloading for OF devices with generic compatible property")
    Signed-off-by: default avatarMauricio Faria de Oliveira <mfo@canonical.com>
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    cbc3d00c
file2alias.c 46.4 KB