• Kumar Kartikeya Dwivedi's avatar
    bpf: Add 'release on unlock' logic for bpf_list_push_{front,back} · 534e86bc
    Kumar Kartikeya Dwivedi authored
    This commit implements the delayed release logic for bpf_list_push_front
    and bpf_list_push_back.
    
    Once a node has been added to the list, it's pointer changes to
    PTR_UNTRUSTED. However, it is only released once the lock protecting the
    list is unlocked. For such PTR_TO_BTF_ID | MEM_ALLOC with PTR_UNTRUSTED
    set but an active ref_obj_id, it is still permitted to read them as long
    as the lock is held. Writing to them is not allowed.
    
    This allows having read access to push items we no longer own until we
    release the lock guarding the list, allowing a little more flexibility
    when working with these APIs.
    
    Note that enabling write support has fairly tricky interactions with
    what happens inside the critical section. Just as an example, currently,
    bpf_obj_drop is not permitted, but if it were, being able to write to
    the PTR_UNTRUSTED pointer while the object gets released back to the
    memory allocator would violate safety properties we wish to guarantee
    (i.e. not crashing the kernel). The memory could be reused for a
    different type in the BPF program or even in the kernel as it gets
    eventually kfree'd.
    
    Not enabling bpf_obj_drop inside the critical section would appear to
    prevent all of the above, but that is more of an artifical limitation
    right now. Since the write support is tangled with how we handle
    potential aliasing of nodes inside the critical section that may or may
    not be part of the list anymore, it has been deferred to a future patch.
    Acked-by: default avatarDave Marchevsky <davemarchevsky@fb.com>
    Signed-off-by: default avatarKumar Kartikeya Dwivedi <memxor@gmail.com>
    Link: https://lore.kernel.org/r/20221118015614.2013203-18-memxor@gmail.comSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    534e86bc
bpf_verifier.h 23.8 KB