• Dongsheng Yang's avatar
    bcache: fix race between setting bdev state to none and new write request direct to backing · df4ad532
    Dongsheng Yang authored
    There is a race condition in detaching as below:
    A. detaching			B. Write request
    (1) writing back
    (2) write back done, set bdev
        state to clean.
    (3) cached_dev_put() and
        schedule_work(&dc->detach);
    				(4) write data [0 - 4K] directly
    				    into backing and ack to user.
    (5) power-failure...
    
    When we restart this bcache device, this bdev is clean but not detached,
    and read [0 - 4K], we will get unexpected old data from cache device.
    
    To fix this problem, set the bdev state to none when we writeback done
    in detaching, and then if power-failure happened as above, the data in
    cache will not be used in next bcache device starting, it's detached, we
    will read the correct data from backing derectly.
    Signed-off-by: default avatarDongsheng Yang <dongsheng.yang@easystack.cn>
    Signed-off-by: default avatarColy Li <colyli@suse.de>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    df4ad532
writeback.c 26 KB