• Ian Rogers's avatar
    perf cap: Tidy up and improve capability testing · e25ebda7
    Ian Rogers authored
    Remove dependence on libcap. libcap is only used to query whether a
    capability is supported, which is just 1 capget system call.
    
    If the capget system call fails, fall back on root permission
    checking. Previously if libcap fails then the permission is assumed
    not present which may be pessimistic/wrong.
    
    Add a used_root out argument to perf_cap__capable to say whether the
    fall back root check was used. This allows the correct error message,
    "root" vs "users with the CAP_PERFMON or CAP_SYS_ADMIN capability", to
    be selected.
    
    Tidy uses of perf_cap__capable so that tests aren't repeated if capget
    isn't supported.
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
    Cc: Changbin Du <changbin.du@huawei.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Leo Yan <leo.yan@linux.dev>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Oliver Upton <oliver.upton@linux.dev>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://lore.kernel.org/r/20240806220614.831914-1-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    e25ebda7
util.c 11.1 KB