• Xu Yang's avatar
    usb: gadget: uvc: queue pump work in uvcg_video_enable() · b52a07e0
    Xu Yang authored
    Since commit "6acba034 usb:gadget:uvc Do not use worker thread to pump
    isoc usb requests", pump work could only be queued in uvc_video_complete()
    and uvc_v4l2_qbuf(). If VIDIOC_QBUF is executed before VIDIOC_STREAMON,
    we can only depend on uvc_video_complete() to queue pump work. However,
    this requires some free requests in req_ready list. If req_ready list is
    empty all the time, pump work will never be queued and video datas will
    never be pumped to usb controller. Actually, this situation could happen
    when run uvc-gadget with static image:
    
    $ ./uvc-gadget -i 1080p.jpg uvc.0
    
    When capture image from this device, the user app will always block there.
    
    The issue is uvc driver has queued video buffer before streamon, but the
    req_ready list is empty all the time after streamon. This will queue pump
    work in uvcg_video_enable() to fill some request to req_ready list so the
    uvc device could work properly.
    
    Fixes: 6acba034 ("usb:gadget:uvc Do not use worker thread to pump isoc usb requests")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarXu Yang <xu.yang_2@nxp.com>
    Link: https://lore.kernel.org/r/20240814112537.2608949-1-xu.yang_2@nxp.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    b52a07e0
uvc_video.c 20.7 KB