• Linus Torvalds's avatar
    Merge tag 'Wimplicit-fallthrough-clang-5.14-rc2' of... · e9338abf
    Linus Torvalds authored
    Merge tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux
    
    Pull fallthrough fixes from Gustavo Silva:
     "This fixes many fall-through warnings when building with Clang and
      -Wimplicit-fallthrough, and also enables -Wimplicit-fallthrough for
      Clang, globally.
    
      It's also important to notice that since we have adopted the use of
      the pseudo-keyword macro fallthrough, we also want to avoid having
      more /* fall through */ comments being introduced. Contrary to GCC,
      Clang doesn't recognize any comments as implicit fall-through markings
      when the -Wimplicit-fallthrough option is enabled.
    
      So, in order to avoid having more comments being introduced, we use
      the option -Wimplicit-fallthrough=5 for GCC, which similar to Clang,
      will cause a warning in case a code comment is intended to be used as
      a fall-through marking. The patch for Makefile also enforces this.
    
      We had almost 4,000 of these issues for Clang in the beginning, and
      there might be a couple more out there when building some
      architectures with certain configurations. However, with the recent
      fixes I think we are in good shape and it is now possible to enable
      the warning for Clang"
    
    * tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: (27 commits)
      Makefile: Enable -Wimplicit-fallthrough for Clang
      powerpc/smp: Fix fall-through warning for Clang
      dmaengine: mpc512x: Fix fall-through warning for Clang
      usb: gadget: fsl_qe_udc: Fix fall-through warning for Clang
      powerpc/powernv: Fix fall-through warning for Clang
      MIPS: Fix unreachable code issue
      MIPS: Fix fall-through warnings for Clang
      ASoC: Mediatek: MT8183: Fix fall-through warning for Clang
      power: supply: Fix fall-through warnings for Clang
      dmaengine: ti: k3-udma: Fix fall-through warning for Clang
      s390: Fix fall-through warnings for Clang
      dmaengine: ipu: Fix fall-through warning for Clang
      iommu/arm-smmu-v3: Fix fall-through warning for Clang
      mmc: jz4740: Fix fall-through warning for Clang
      PCI: Fix fall-through warning for Clang
      scsi: libsas: Fix fall-through warning for Clang
      video: fbdev: Fix fall-through warning for Clang
      math-emu: Fix fall-through warning
      cpufreq: Fix fall-through warning for Clang
      drm/msm: Fix fall-through warning in msm_gem_new_impl()
      ...
    e9338abf
conntrack.c 31.2 KB