• Colin Ian King's avatar
    io_uring: fix shadowed variable ret return code being not checked · efeb862b
    Colin Ian King authored
    Currently variable ret is declared in a while-loop code block that
    shadows another variable ret. When an error occurs in the while-loop
    the error return in ret is not being set in the outer code block and
    so the error check on ret is always going to be checking on the wrong
    ret variable resulting in check that is always going to be true and
    a premature return occurs.
    
    Fix this by removing the declaration of the inner while-loop variable
    ret so that shadowing does not occur.
    
    Addresses-Coverity: ("'Constant' variable guards dead code")
    Fixes: 6b06314c ("io_uring: add file set registration")
    Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    efeb862b
io_uring.c 76.4 KB