Commit 009482c0 authored by Yang Guang's avatar Yang Guang Committed by Shuah Khan

selftests/move_mount_set_group remove unneeded conversion to bool

The coccinelle report
./tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c:225:18-23:
WARNING: conversion to bool not needed here
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.
Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarYang Guang <yang.guang5@zte.com.cn>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 6d425d7c
...@@ -191,7 +191,7 @@ static bool is_shared_mount(const char *path) ...@@ -191,7 +191,7 @@ static bool is_shared_mount(const char *path)
#define SET_GROUP_FROM "/tmp/move_mount_set_group_supported_from" #define SET_GROUP_FROM "/tmp/move_mount_set_group_supported_from"
#define SET_GROUP_TO "/tmp/move_mount_set_group_supported_to" #define SET_GROUP_TO "/tmp/move_mount_set_group_supported_to"
static int move_mount_set_group_supported(void) static bool move_mount_set_group_supported(void)
{ {
int ret; int ret;
...@@ -222,7 +222,7 @@ static int move_mount_set_group_supported(void) ...@@ -222,7 +222,7 @@ static int move_mount_set_group_supported(void)
AT_FDCWD, SET_GROUP_TO, MOVE_MOUNT_SET_GROUP); AT_FDCWD, SET_GROUP_TO, MOVE_MOUNT_SET_GROUP);
umount2("/tmp", MNT_DETACH); umount2("/tmp", MNT_DETACH);
return ret < 0 ? false : true; return ret >= 0;
} }
FIXTURE(move_mount_set_group) { FIXTURE(move_mount_set_group) {
...@@ -232,7 +232,7 @@ FIXTURE(move_mount_set_group) { ...@@ -232,7 +232,7 @@ FIXTURE(move_mount_set_group) {
FIXTURE_SETUP(move_mount_set_group) FIXTURE_SETUP(move_mount_set_group)
{ {
int ret; bool ret;
ASSERT_EQ(prepare_unpriv_mountns(), 0); ASSERT_EQ(prepare_unpriv_mountns(), 0);
...@@ -254,7 +254,7 @@ FIXTURE_SETUP(move_mount_set_group) ...@@ -254,7 +254,7 @@ FIXTURE_SETUP(move_mount_set_group)
FIXTURE_TEARDOWN(move_mount_set_group) FIXTURE_TEARDOWN(move_mount_set_group)
{ {
int ret; bool ret;
ret = move_mount_set_group_supported(); ret = move_mount_set_group_supported();
ASSERT_GE(ret, 0); ASSERT_GE(ret, 0);
...@@ -348,7 +348,7 @@ TEST_F(move_mount_set_group, complex_sharing_copying) ...@@ -348,7 +348,7 @@ TEST_F(move_mount_set_group, complex_sharing_copying)
.shared = false, .shared = false,
}; };
pid_t pid; pid_t pid;
int ret; bool ret;
ret = move_mount_set_group_supported(); ret = move_mount_set_group_supported();
ASSERT_GE(ret, 0); ASSERT_GE(ret, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment