Commit 010848a7 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Inki Dae

drm: exynos: make PM functions as __maybe_unused

The newly added runtime-pm support for exynos-drm encloses the
pm functions in an #ifdef, but not the functions that are called
from them and nowhere else, which produces warnings:

drm/exynos/exynos_drm_dsi.c:733:13: warning: 'exynos_dsi_disable_clock' defined but not used [-Wunused-function]
 static void exynos_dsi_disable_clock(struct exynos_dsi *dsi)
             ^
drm/exynos/exynos_drm_dsi.c:1291:13: warning: 'exynos_dsi_disable_irq' defined but not used [-Wunused-function]
 static void exynos_dsi_disable_irq(struct exynos_dsi *dsi)
             ^

This removes the #ifdef and instead marks the functions as
__maybe_unused, so gcc can silently discard them and all called
functions when CONFIG_PM is disabled.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent e0fea7e7
...@@ -1906,8 +1906,7 @@ static int exynos_dsi_remove(struct platform_device *pdev) ...@@ -1906,8 +1906,7 @@ static int exynos_dsi_remove(struct platform_device *pdev)
return 0; return 0;
} }
#ifdef CONFIG_PM static int __maybe_unused exynos_dsi_suspend(struct device *dev)
static int exynos_dsi_suspend(struct device *dev)
{ {
struct drm_encoder *encoder = dev_get_drvdata(dev); struct drm_encoder *encoder = dev_get_drvdata(dev);
struct exynos_dsi *dsi = encoder_to_dsi(encoder); struct exynos_dsi *dsi = encoder_to_dsi(encoder);
...@@ -1938,7 +1937,7 @@ static int exynos_dsi_suspend(struct device *dev) ...@@ -1938,7 +1937,7 @@ static int exynos_dsi_suspend(struct device *dev)
return 0; return 0;
} }
static int exynos_dsi_resume(struct device *dev) static int __maybe_unused exynos_dsi_resume(struct device *dev)
{ {
struct drm_encoder *encoder = dev_get_drvdata(dev); struct drm_encoder *encoder = dev_get_drvdata(dev);
struct exynos_dsi *dsi = encoder_to_dsi(encoder); struct exynos_dsi *dsi = encoder_to_dsi(encoder);
...@@ -1972,7 +1971,6 @@ static int exynos_dsi_resume(struct device *dev) ...@@ -1972,7 +1971,6 @@ static int exynos_dsi_resume(struct device *dev)
return ret; return ret;
} }
#endif
static const struct dev_pm_ops exynos_dsi_pm_ops = { static const struct dev_pm_ops exynos_dsi_pm_ops = {
SET_RUNTIME_PM_OPS(exynos_dsi_suspend, exynos_dsi_resume, NULL) SET_RUNTIME_PM_OPS(exynos_dsi_suspend, exynos_dsi_resume, NULL)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment