Commit 0150d1bf authored by Borislav Petkov (AMD)'s avatar Borislav Petkov (AMD)

tools/x86/kcpuid: Dump the correct CPUID function in error

The tool uses the 16 least significant bits of the CPUID leaf as an
index into its array of CPUID function field descriptions.

However, when that index is non-existent, it uses the same, truncated
index to report it, which is wrong:

$ kcpuid -l 0x80000034
  ERR: invalid input index (0x34)

Use the original index number in the error message.
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20230426094107.27348-1-bp@alien8.de
parent ac9a7868
...@@ -517,15 +517,16 @@ static void show_range(struct cpuid_range *range) ...@@ -517,15 +517,16 @@ static void show_range(struct cpuid_range *range)
static inline struct cpuid_func *index_to_func(u32 index) static inline struct cpuid_func *index_to_func(u32 index)
{ {
struct cpuid_range *range; struct cpuid_range *range;
u32 func_idx;
range = (index & 0x80000000) ? leafs_ext : leafs_basic; range = (index & 0x80000000) ? leafs_ext : leafs_basic;
index &= 0x7FFFFFFF; func_idx = index & 0xffff;
if (((index & 0xFFFF) + 1) > (u32)range->nr) { if ((func_idx + 1) > (u32)range->nr) {
printf("ERR: invalid input index (0x%x)\n", index); printf("ERR: invalid input index (0x%x)\n", index);
return NULL; return NULL;
} }
return &range->funcs[index]; return &range->funcs[func_idx];
} }
static void show_info(void) static void show_info(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment