Commit 0173c895 authored by Andy Green's avatar Andy Green Committed by Vinod Koul

k3dma: Fix "nobody cared" message seen on any error

As it was before, as soon as the DMAC IP felt there was an error
he would return IRQ_NONE since no actual transfer had completed.

After spinning on that for 100K interrupts, Linux yanks the IRQ with
a "nobody cared" error.

This patch lets it handle the interrupt and keep the IRQ alive.

Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Andy Green <andy@warmcat.com>
Acked-by: default avatarZhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: default avatarAndy Green <andy.green@linaro.org>
[jstultz: Forward ported to mainline]
Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent aceaaa17
...@@ -221,10 +221,12 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id) ...@@ -221,10 +221,12 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id)
writel_relaxed(err1, d->base + INT_ERR1_RAW); writel_relaxed(err1, d->base + INT_ERR1_RAW);
writel_relaxed(err2, d->base + INT_ERR2_RAW); writel_relaxed(err2, d->base + INT_ERR2_RAW);
if (irq_chan) { if (irq_chan)
tasklet_schedule(&d->task); tasklet_schedule(&d->task);
if (irq_chan || err1 || err2)
return IRQ_HANDLED; return IRQ_HANDLED;
} else
return IRQ_NONE; return IRQ_NONE;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment