Commit 01d1d714 authored by Ernst Martin Witte's avatar Ernst Martin Witte Committed by Mauro Carvalho Chehab

[media] si2157: cancel_delayed_work_sync before device removal / kfree

si2157_remove  was  calling  kfree(dev)  with  possibly  still  active
schedule_delayed_work(dev->stat_work).  This  caused kernel  panics in
call_timer_fn e.g. after rmmod cx23885.
Signed-off-by: default avatarErnst Martin Witte <emw-linux-kernel@nocabal.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 4bdcaa05
...@@ -458,6 +458,9 @@ static int si2157_remove(struct i2c_client *client) ...@@ -458,6 +458,9 @@ static int si2157_remove(struct i2c_client *client)
dev_dbg(&client->dev, "\n"); dev_dbg(&client->dev, "\n");
/* stop statistics polling */
cancel_delayed_work_sync(&dev->stat_work);
memset(&fe->ops.tuner_ops, 0, sizeof(struct dvb_tuner_ops)); memset(&fe->ops.tuner_ops, 0, sizeof(struct dvb_tuner_ops));
fe->tuner_priv = NULL; fe->tuner_priv = NULL;
kfree(dev); kfree(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment