Commit 023859ce authored by Thiago Rafael Becker's avatar Thiago Rafael Becker Committed by Trond Myklebust

sunrpc: remove unnecessary test in rpc_task_set_client()

In rpc_task_set_client(), testing for a NULL clnt is not necessary, as
clnt should always be a valid pointer to a rpc_client.
Signed-off-by: default avatarThiago Rafael Becker <trbecker@gmail.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 5fe1210d
...@@ -1076,24 +1076,21 @@ void rpc_task_set_transport(struct rpc_task *task, struct rpc_clnt *clnt) ...@@ -1076,24 +1076,21 @@ void rpc_task_set_transport(struct rpc_task *task, struct rpc_clnt *clnt)
static static
void rpc_task_set_client(struct rpc_task *task, struct rpc_clnt *clnt) void rpc_task_set_client(struct rpc_task *task, struct rpc_clnt *clnt)
{ {
rpc_task_set_transport(task, clnt);
if (clnt != NULL) { task->tk_client = clnt;
rpc_task_set_transport(task, clnt); refcount_inc(&clnt->cl_count);
task->tk_client = clnt; if (clnt->cl_softrtry)
refcount_inc(&clnt->cl_count); task->tk_flags |= RPC_TASK_SOFT;
if (clnt->cl_softrtry) if (clnt->cl_softerr)
task->tk_flags |= RPC_TASK_SOFT; task->tk_flags |= RPC_TASK_TIMEOUT;
if (clnt->cl_softerr) if (clnt->cl_noretranstimeo)
task->tk_flags |= RPC_TASK_TIMEOUT; task->tk_flags |= RPC_TASK_NO_RETRANS_TIMEOUT;
if (clnt->cl_noretranstimeo) if (atomic_read(&clnt->cl_swapper))
task->tk_flags |= RPC_TASK_NO_RETRANS_TIMEOUT; task->tk_flags |= RPC_TASK_SWAPPER;
if (atomic_read(&clnt->cl_swapper)) /* Add to the client's list of all tasks */
task->tk_flags |= RPC_TASK_SWAPPER; spin_lock(&clnt->cl_lock);
/* Add to the client's list of all tasks */ list_add_tail(&task->tk_task, &clnt->cl_tasks);
spin_lock(&clnt->cl_lock); spin_unlock(&clnt->cl_lock);
list_add_tail(&task->tk_task, &clnt->cl_tasks);
spin_unlock(&clnt->cl_lock);
}
} }
static void static void
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment