Commit 02b2fb45 authored by zhouchuangao's avatar zhouchuangao Committed by Jessica Yu

kernel/module: Use BUG_ON instead of if condition followed by BUG

Fix the following coccinelle report:

kernel/module.c:1018:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

BUG_ON uses unlikely in if(). Through disassembly, we can see that
brk #0x800 is compiled to the end of the function.
As you can see below:
    ......
    ffffff8008660bec:   d65f03c0    ret
    ffffff8008660bf0:   d4210000    brk #0x800

Usually, the condition in if () is not satisfied. For the
multi-stage pipeline, we do not need to perform fetch decode
and excute operation on brk instruction.

In my opinion, this can improve the efficiency of the
multi-stage pipeline.
Signed-off-by: default avatarzhouchuangao <zhouchuangao@vivo.com>
Signed-off-by: default avatarJessica Yu <jeyu@kernel.org>
parent 6efb943b
...@@ -1014,8 +1014,7 @@ void __symbol_put(const char *symbol) ...@@ -1014,8 +1014,7 @@ void __symbol_put(const char *symbol)
}; };
preempt_disable(); preempt_disable();
if (!find_symbol(&fsa)) BUG_ON(!find_symbol(&fsa));
BUG();
module_put(fsa.owner); module_put(fsa.owner);
preempt_enable(); preempt_enable();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment