Commit 03ceace5 authored by Jeff Layton's avatar Jeff Layton Committed by Steve French

cifs: fix check of error return from is_path_accessable

This function will return 0 if everything went ok. Commit 9d002df4
however added a block of code after the following check for
rc == -EREMOTE. With that change and when rc == 0, doing the
"goto mount_fail_check" here skips that code, leaving the tlink_tree
and master_tlink pointer unpopulated. That causes an oops later
in cifs_root_iget.
Reported-and-Tested-by: default avatarRobbert Kouprie <robbert@exx.nl>
Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 88463999
...@@ -2839,7 +2839,7 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb, ...@@ -2839,7 +2839,7 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
goto mount_fail_check; goto mount_fail_check;
} }
rc = is_path_accessible(xid, tcon, cifs_sb, full_path); rc = is_path_accessible(xid, tcon, cifs_sb, full_path);
if (rc != -EREMOTE) { if (rc != 0 && rc != -EREMOTE) {
kfree(full_path); kfree(full_path);
goto mount_fail_check; goto mount_fail_check;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment