Commit 0471a448 authored by Chris Wilson's avatar Chris Wilson

drm/i915/gt: Bump the PP_DIR invalidation for Baytrail

Invalidate the ring TLB and increase the delay required for Baytrail.
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Acked-by: default avatarMika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191205113726.413351-3-chris@chris-wilson.co.uk
parent ccd20945
...@@ -1396,6 +1396,25 @@ static int load_pd_dir(struct i915_request *rq, const struct i915_ppgtt *ppgtt) ...@@ -1396,6 +1396,25 @@ static int load_pd_dir(struct i915_request *rq, const struct i915_ppgtt *ppgtt)
return 0; return 0;
} }
static int flush_tlb(struct i915_request *rq)
{
const struct intel_engine_cs * const engine = rq->engine;
u32 *cs;
cs = intel_ring_begin(rq, 4);
if (IS_ERR(cs))
return PTR_ERR(cs);
*cs++ = MI_LOAD_REGISTER_IMM(1);
*cs++ = i915_mmio_reg_offset(RING_INSTPM(engine->mmio_base));
*cs++ = _MASKED_BIT_ENABLE(INSTPM_TLB_INVALIDATE);
*cs++ = MI_NOOP;
intel_ring_advance(rq, cs);
return 0;
}
static inline int mi_set_context(struct i915_request *rq, u32 flags) static inline int mi_set_context(struct i915_request *rq, u32 flags)
{ {
struct drm_i915_private *i915 = rq->i915; struct drm_i915_private *i915 = rq->i915;
...@@ -1588,16 +1607,28 @@ static int switch_context(struct i915_request *rq) ...@@ -1588,16 +1607,28 @@ static int switch_context(struct i915_request *rq)
* post-sync op, this extra pass appears vital before a * post-sync op, this extra pass appears vital before a
* mm switch! * mm switch!
*/ */
do { ret = rq->engine->emit_flush(rq, EMIT_INVALIDATE);
ret = rq->engine->emit_flush(rq, EMIT_FLUSH);
if (ret) if (ret)
return ret; return ret;
ret = flush_tlb(rq);
if (ret)
return ret;
do {
ret = load_pd_dir(rq, i915_vm_to_ppgtt(vm)); ret = load_pd_dir(rq, i915_vm_to_ppgtt(vm));
if (ret) if (ret)
return ret; return ret;
} while (--loops); } while (--loops);
ret = flush_tlb(rq);
if (ret)
return ret;
ret = rq->engine->emit_flush(rq, EMIT_FLUSH);
if (ret)
return ret;
ret = rq->engine->emit_flush(rq, EMIT_INVALIDATE); ret = rq->engine->emit_flush(rq, EMIT_INVALIDATE);
if (ret) if (ret)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment