Commit 0497b345 authored by Jens Axboe's avatar Jens Axboe

blktrace: use BLKTRACE_BDEV_SIZE as the name size for setup structure

Define as 32, which is is what BDEVNAME_SIZE is/was as well. This keeps
the user interface the same and gets rid of the difference between
kernel and user api here.
Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
parent ef9e3fac
...@@ -369,7 +369,8 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev, ...@@ -369,7 +369,8 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
if (!buts->buf_size || !buts->buf_nr) if (!buts->buf_size || !buts->buf_nr)
return -EINVAL; return -EINVAL;
strcpy(buts->name, name); strncpy(buts->name, name, BLKTRACE_BDEV_SIZE);
buts->name[BLKTRACE_BDEV_SIZE - 1] = '\0';
/* /*
* some device names have larger paths - convert the slashes * some device names have larger paths - convert the slashes
......
...@@ -122,15 +122,13 @@ enum { ...@@ -122,15 +122,13 @@ enum {
Blktrace_stopped, Blktrace_stopped,
}; };
#define BLKTRACE_BDEV_SIZE 32
/* /*
* User setup structure passed with BLKTRACESTART * User setup structure passed with BLKTRACESTART
*/ */
struct blk_user_trace_setup { struct blk_user_trace_setup {
#ifdef __KERNEL__ char name[BLKTRACE_BDEV_SIZE]; /* output */
char name[BDEVNAME_SIZE]; /* output */
#else
char name[32]; /* output */
#endif
__u16 act_mask; /* input */ __u16 act_mask; /* input */
__u32 buf_size; /* input */ __u32 buf_size; /* input */
__u32 buf_nr; /* input */ __u32 buf_nr; /* input */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment