Skip to content

L
linux
Commit 05394f39 authored by Chris Wilson's avatar Chris Wilson
Browse files
Options

drm/i915: Use drm_i915_gem_object as the preferred type 

A glorified s/obj_priv/obj/ with a net reduction of over a 100 lines and
many characters!
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 185cbcb3
Expand all Show whitespace changes
Inline Side-by-side
Showing with 1019 additions and 1157 deletions
drivers/gpu/drm/i915/i915_debugfs.c
View file @ 05394f39
...@@ -87,19 +87,19 @@ static int i915_capabilities(struct seq_file *m, void *data) ...@@ -87,19 +87,19 @@ static int i915_capabilities(struct seq_file *m, void *data)
return 0; return 0;
} }
static const char *get_pin_flag(struct drm_i915_gem_object *obj_priv) static const char *get_pin_flag(struct drm_i915_gem_object *obj)
{ {
if (obj_priv->user_pin_count > 0) if (obj->user_pin_count > 0)
return "P"; return "P";
else if (obj_priv->pin_count > 0) else if (obj->pin_count > 0)
return "p"; return "p";
else else
return " "; return " ";
} }
static const char *get_tiling_flag(struct drm_i915_gem_object *obj_priv) static const char *get_tiling_flag(struct drm_i915_gem_object *obj)
{ {
switch (obj_priv->tiling_mode) { switch (obj->tiling_mode) {
default: default:
case I915_TILING_NONE: return " "; case I915_TILING_NONE: return " ";
case I915_TILING_X: return "X"; case I915_TILING_X: return "X";
...@@ -140,7 +140,7 @@ static int i915_gem_object_list_info(struct seq_file *m, void *data) ...@@ -140,7 +140,7 @@ static int i915_gem_object_list_info(struct seq_file *m, void *data)
struct list_head *head; struct list_head *head;
struct drm_device *dev = node->minor->dev; struct drm_device *dev = node->minor->dev;
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj_priv; struct drm_i915_gem_object *obj;
size_t total_obj_size, total_gtt_size; size_t total_obj_size, total_gtt_size;
int count, ret; int count, ret;
...@@ -175,12 +175,12 @@ static int i915_gem_object_list_info(struct seq_file *m, void *data) ...@@ -175,12 +175,12 @@ static int i915_gem_object_list_info(struct seq_file *m, void *data)
} }
total_obj_size = total_gtt_size = count = 0; total_obj_size = total_gtt_size = count = 0;
list_for_each_entry(obj_priv, head, mm_list) { list_for_each_entry(obj, head, mm_list) {
seq_printf(m, " "); seq_printf(m, " ");
describe_obj(m, obj_priv); describe_obj(m, obj);
seq_printf(m, "\n"); seq_printf(m, "\n");
total_obj_size += obj_priv->base.size; total_obj_size += obj->base.size;
total_gtt_size += obj_priv->gtt_space->size; total_gtt_size += obj->gtt_space->size;
count++; count++;
} }
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
...@@ -251,14 +251,14 @@ static int i915_gem_pageflip_info(struct seq_file *m, void *data) ...@@ -251,14 +251,14 @@ static int i915_gem_pageflip_info(struct seq_file *m, void *data)
seq_printf(m, "%d prepares\n", work->pending); seq_printf(m, "%d prepares\n", work->pending);
if (work->old_fb_obj) { if (work->old_fb_obj) {
struct drm_i915_gem_object *obj_priv = to_intel_bo(work->old_fb_obj); struct drm_i915_gem_object *obj = work->old_fb_obj;
if(obj_priv) if (obj)
seq_printf(m, "Old framebuffer gtt_offset 0x%08x\n", obj_priv->gtt_offset ); seq_printf(m, "Old framebuffer gtt_offset 0x%08x\n", obj->gtt_offset);
} }
if (work->pending_flip_obj) { if (work->pending_flip_obj) {
struct drm_i915_gem_object *obj_priv = to_intel_bo(work->pending_flip_obj); struct drm_i915_gem_object *obj = work->pending_flip_obj;
if(obj_priv) if (obj)
seq_printf(m, "New framebuffer gtt_offset 0x%08x\n", obj_priv->gtt_offset ); seq_printf(m, "New framebuffer gtt_offset 0x%08x\n", obj->gtt_offset);
} }
} }
spin_unlock_irqrestore(&dev->event_lock, flags); spin_unlock_irqrestore(&dev->event_lock, flags);
...@@ -421,17 +421,17 @@ static int i915_gem_fence_regs_info(struct seq_file *m, void *data) ...@@ -421,17 +421,17 @@ static int i915_gem_fence_regs_info(struct seq_file *m, void *data)
seq_printf(m, "Reserved fences = %d\n", dev_priv->fence_reg_start); seq_printf(m, "Reserved fences = %d\n", dev_priv->fence_reg_start);
seq_printf(m, "Total fences = %d\n", dev_priv->num_fence_regs); seq_printf(m, "Total fences = %d\n", dev_priv->num_fence_regs);
for (i = 0; i < dev_priv->num_fence_regs; i++) { for (i = 0; i < dev_priv->num_fence_regs; i++) {
struct drm_gem_object *obj = dev_priv->fence_regs[i].obj; struct drm_i915_gem_object *obj = dev_priv->fence_regs[i].obj;
seq_printf(m, "Fenced object[%2d] = ", i); seq_printf(m, "Fenced object[%2d] = ", i);
if (obj == NULL) if (obj == NULL)
seq_printf(m, "unused"); seq_printf(m, "unused");
else else
describe_obj(m, to_intel_bo(obj)); describe_obj(m, obj);
seq_printf(m, "\n"); seq_printf(m, "\n");
} }
mutex_unlock(&dev->struct_mutex);
mutex_unlock(&dev->struct_mutex);
return 0; return 0;
} }
...@@ -465,14 +465,14 @@ static int i915_hws_info(struct seq_file *m, void *data) ...@@ -465,14 +465,14 @@ static int i915_hws_info(struct seq_file *m, void *data)
static void i915_dump_object(struct seq_file *m, static void i915_dump_object(struct seq_file *m,
struct io_mapping *mapping, struct io_mapping *mapping,
struct drm_i915_gem_object *obj_priv) struct drm_i915_gem_object *obj)
{ {
int page, page_count, i; int page, page_count, i;
page_count = obj_priv->base.size / PAGE_SIZE; page_count = obj->base.size / PAGE_SIZE;
for (page = 0; page < page_count; page++) { for (page = 0; page < page_count; page++) {
u32 *mem = io_mapping_map_wc(mapping, u32 *mem = io_mapping_map_wc(mapping,
obj_priv->gtt_offset + page * PAGE_SIZE); obj->gtt_offset + page * PAGE_SIZE);
for (i = 0; i < PAGE_SIZE; i += 4) for (i = 0; i < PAGE_SIZE; i += 4)
seq_printf(m, "%08x : %08x\n", i, mem[i / 4]); seq_printf(m, "%08x : %08x\n", i, mem[i / 4]);
io_mapping_unmap(mem); io_mapping_unmap(mem);
...@@ -484,25 +484,21 @@ static int i915_batchbuffer_info(struct seq_file *m, void *data) ...@@ -484,25 +484,21 @@ static int i915_batchbuffer_info(struct seq_file *m, void *data)
struct drm_info_node *node = (struct drm_info_node *) m->private; struct drm_info_node *node = (struct drm_info_node *) m->private;
struct drm_device *dev = node->minor->dev; struct drm_device *dev = node->minor->dev;
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_gem_object *obj; struct drm_i915_gem_object *obj;
struct drm_i915_gem_object *obj_priv;
int ret; int ret;
ret = mutex_lock_interruptible(&dev->struct_mutex); ret = mutex_lock_interruptible(&dev->struct_mutex);
if (ret) if (ret)
return ret; return ret;
list_for_each_entry(obj_priv, &dev_priv->mm.active_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.active_list, mm_list) {
obj = &obj_priv->base; if (obj->base.read_domains & I915_GEM_DOMAIN_COMMAND) {
if (obj->read_domains & I915_GEM_DOMAIN_COMMAND) { seq_printf(m, "--- gtt_offset = 0x%08x\n", obj->gtt_offset);
seq_printf(m, "--- gtt_offset = 0x%08x\n", i915_dump_object(m, dev_priv->mm.gtt_mapping, obj);
obj_priv->gtt_offset);
i915_dump_object(m, dev_priv->mm.gtt_mapping, obj_priv);
} }
} }
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
return 0; return 0;
} }
...@@ -525,7 +521,7 @@ static int i915_ringbuffer_data(struct seq_file *m, void *data) ...@@ -525,7 +521,7 @@ static int i915_ringbuffer_data(struct seq_file *m, void *data)
if (ret) if (ret)
return ret; return ret;
if (!ring->gem_object) { if (!ring->obj) {
seq_printf(m, "No ringbuffer setup\n"); seq_printf(m, "No ringbuffer setup\n");
} else { } else {
u8 *virt = ring->virtual_start; u8 *virt = ring->virtual_start;
...@@ -983,7 +979,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) ...@@ -983,7 +979,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data)
fb->base.height, fb->base.height,
fb->base.depth, fb->base.depth,
fb->base.bits_per_pixel); fb->base.bits_per_pixel);
describe_obj(m, to_intel_bo(fb->obj)); describe_obj(m, fb->obj);
seq_printf(m, "\n"); seq_printf(m, "\n");
list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) { list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) {
...@@ -995,7 +991,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data) ...@@ -995,7 +991,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data)
fb->base.height, fb->base.height,
fb->base.depth, fb->base.depth,
fb->base.bits_per_pixel); fb->base.bits_per_pixel);
describe_obj(m, to_intel_bo(fb->obj)); describe_obj(m, fb->obj);
seq_printf(m, "\n"); seq_printf(m, "\n");
} }
......
drivers/gpu/drm/i915/i915_dma.c
View file @ 05394f39
...@@ -157,7 +157,7 @@ static int i915_initialize(struct drm_device * dev, drm_i915_init_t * init) ...@@ -157,7 +157,7 @@ static int i915_initialize(struct drm_device * dev, drm_i915_init_t * init)
} }
if (init->ring_size != 0) { if (init->ring_size != 0) {
if (dev_priv->render_ring.gem_object != NULL) { if (dev_priv->render_ring.obj != NULL) {
i915_dma_cleanup(dev); i915_dma_cleanup(dev);
DRM_ERROR("Client tried to initialize ringbuffer in " DRM_ERROR("Client tried to initialize ringbuffer in "
"GEM mode\n"); "GEM mode\n");
......
drivers/gpu/drm/i915/i915_drv.h
View file @ 05394f39
...@@ -32,7 +32,6 @@ ...@@ -32,7 +32,6 @@
#include "i915_reg.h" #include "i915_reg.h"
#include "intel_bios.h" #include "intel_bios.h"
#include "i915_trace.h"
#include "intel_ringbuffer.h" #include "intel_ringbuffer.h"
#include <linux/io-mapping.h> #include <linux/io-mapping.h>
#include <linux/i2c.h> #include <linux/i2c.h>
...@@ -90,7 +89,7 @@ struct drm_i915_gem_phys_object { ...@@ -90,7 +89,7 @@ struct drm_i915_gem_phys_object {
int id; int id;
struct page **page_list; struct page **page_list;
drm_dma_handle_t *handle; drm_dma_handle_t *handle;
struct drm_gem_object *cur_obj; struct drm_i915_gem_object *cur_obj;
}; };
struct mem_block { struct mem_block {
...@@ -125,7 +124,7 @@ struct drm_i915_master_private { ...@@ -125,7 +124,7 @@ struct drm_i915_master_private {
#define I915_FENCE_REG_NONE -1 #define I915_FENCE_REG_NONE -1
struct drm_i915_fence_reg { struct drm_i915_fence_reg {
struct drm_gem_object *obj; struct drm_i915_gem_object *obj;
struct list_head lru_list; struct list_head lru_list;
bool gpu; bool gpu;
}; };
...@@ -280,9 +279,9 @@ typedef struct drm_i915_private { ...@@ -280,9 +279,9 @@ typedef struct drm_i915_private {
uint32_t counter; uint32_t counter;
unsigned int seqno_gfx_addr; unsigned int seqno_gfx_addr;
drm_local_map_t hws_map; drm_local_map_t hws_map;
struct drm_gem_object *seqno_obj; struct drm_i915_gem_object *seqno_obj;
struct drm_gem_object *pwrctx; struct drm_i915_gem_object *pwrctx;
struct drm_gem_object *renderctx; struct drm_i915_gem_object *renderctx;
struct resource mch_res; struct resource mch_res;
...@@ -711,7 +710,6 @@ typedef struct drm_i915_private { ...@@ -711,7 +710,6 @@ typedef struct drm_i915_private {
struct intel_fbdev *fbdev; struct intel_fbdev *fbdev;
} drm_i915_private_t; } drm_i915_private_t;
/** driver private structure attached to each drm_gem_object */
struct drm_i915_gem_object { struct drm_i915_gem_object {
struct drm_gem_object base; struct drm_gem_object base;
...@@ -947,6 +945,8 @@ enum intel_chip_family { ...@@ -947,6 +945,8 @@ enum intel_chip_family {
#define HAS_PCH_CPT(dev) (INTEL_PCH_TYPE(dev) == PCH_CPT) #define HAS_PCH_CPT(dev) (INTEL_PCH_TYPE(dev) == PCH_CPT)
#define HAS_PCH_IBX(dev) (INTEL_PCH_TYPE(dev) == PCH_IBX) #define HAS_PCH_IBX(dev) (INTEL_PCH_TYPE(dev) == PCH_IBX)
#include "i915_trace.h"
extern struct drm_ioctl_desc i915_ioctls[]; extern struct drm_ioctl_desc i915_ioctls[];
extern int i915_max_ioctl; extern int i915_max_ioctl;
extern unsigned int i915_fbpercrtc; extern unsigned int i915_fbpercrtc;
...@@ -1085,14 +1085,15 @@ int i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data, ...@@ -1085,14 +1085,15 @@ int i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv); struct drm_file *file_priv);
void i915_gem_load(struct drm_device *dev); void i915_gem_load(struct drm_device *dev);
int i915_gem_init_object(struct drm_gem_object *obj); int i915_gem_init_object(struct drm_gem_object *obj);
struct drm_gem_object * i915_gem_alloc_object(struct drm_device *dev, struct drm_i915_gem_object *i915_gem_alloc_object(struct drm_device *dev,
size_t size); size_t size);
void i915_gem_free_object(struct drm_gem_object *obj); void i915_gem_free_object(struct drm_gem_object *obj);
int i915_gem_object_pin(struct drm_gem_object *obj, uint32_t alignment, int i915_gem_object_pin(struct drm_i915_gem_object *obj,
uint32_t alignment,
bool map_and_fenceable); bool map_and_fenceable);
void i915_gem_object_unpin(struct drm_gem_object *obj); void i915_gem_object_unpin(struct drm_i915_gem_object *obj);
int i915_gem_object_unbind(struct drm_gem_object *obj); int i915_gem_object_unbind(struct drm_i915_gem_object *obj);
void i915_gem_release_mmap(struct drm_gem_object *obj); void i915_gem_release_mmap(struct drm_i915_gem_object *obj);
void i915_gem_lastclose(struct drm_device *dev); void i915_gem_lastclose(struct drm_device *dev);
/** /**
...@@ -1104,14 +1105,14 @@ i915_seqno_passed(uint32_t seq1, uint32_t seq2) ...@@ -1104,14 +1105,14 @@ i915_seqno_passed(uint32_t seq1, uint32_t seq2)
return (int32_t)(seq1 - seq2) >= 0; return (int32_t)(seq1 - seq2) >= 0;
} }
int i915_gem_object_get_fence_reg(struct drm_gem_object *obj, int i915_gem_object_get_fence_reg(struct drm_i915_gem_object *obj,
bool interruptible); bool interruptible);
int i915_gem_object_put_fence_reg(struct drm_gem_object *obj, int i915_gem_object_put_fence_reg(struct drm_i915_gem_object *obj,
bool interruptible); bool interruptible);
void i915_gem_retire_requests(struct drm_device *dev); void i915_gem_retire_requests(struct drm_device *dev);
void i915_gem_reset(struct drm_device *dev); void i915_gem_reset(struct drm_device *dev);
void i915_gem_clflush_object(struct drm_gem_object *obj); void i915_gem_clflush_object(struct drm_i915_gem_object *obj);
int i915_gem_object_set_domain(struct drm_gem_object *obj, int i915_gem_object_set_domain(struct drm_i915_gem_object *obj,
uint32_t read_domains, uint32_t read_domains,
uint32_t write_domain); uint32_t write_domain);
int i915_gem_object_flush_gpu(struct drm_i915_gem_object *obj, int i915_gem_object_flush_gpu(struct drm_i915_gem_object *obj,
...@@ -1131,23 +1132,23 @@ int i915_do_wait_request(struct drm_device *dev, ...@@ -1131,23 +1132,23 @@ int i915_do_wait_request(struct drm_device *dev,
bool interruptible, bool interruptible,
struct intel_ring_buffer *ring); struct intel_ring_buffer *ring);
int i915_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf); int i915_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf);
int i915_gem_object_set_to_gtt_domain(struct drm_gem_object *obj, int i915_gem_object_set_to_gtt_domain(struct drm_i915_gem_object *obj,
int write); int write);
int i915_gem_object_set_to_display_plane(struct drm_gem_object *obj, int i915_gem_object_set_to_display_plane(struct drm_i915_gem_object *obj,
bool pipelined); bool pipelined);
int i915_gem_attach_phys_object(struct drm_device *dev, int i915_gem_attach_phys_object(struct drm_device *dev,
struct drm_gem_object *obj, struct drm_i915_gem_object *obj,
int id, int id,
int align); int align);
void i915_gem_detach_phys_object(struct drm_device *dev, void i915_gem_detach_phys_object(struct drm_device *dev,
struct drm_gem_object *obj); struct drm_i915_gem_object *obj);
void i915_gem_free_all_phys_object(struct drm_device *dev); void i915_gem_free_all_phys_object(struct drm_device *dev);
void i915_gem_release(struct drm_device * dev, struct drm_file *file_priv); void i915_gem_release(struct drm_device *dev, struct drm_file *file);
/* i915_gem_gtt.c */ /* i915_gem_gtt.c */
void i915_gem_restore_gtt_mappings(struct drm_device *dev); void i915_gem_restore_gtt_mappings(struct drm_device *dev);
int i915_gem_gtt_bind_object(struct drm_gem_object *obj); int i915_gem_gtt_bind_object(struct drm_i915_gem_object *obj);
void i915_gem_gtt_unbind_object(struct drm_gem_object *obj); void i915_gem_gtt_unbind_object(struct drm_i915_gem_object *obj);
/* i915_gem_evict.c */ /* i915_gem_evict.c */
int i915_gem_evict_something(struct drm_device *dev, int min_size, int i915_gem_evict_something(struct drm_device *dev, int min_size,
...@@ -1157,19 +1158,20 @@ int i915_gem_evict_inactive(struct drm_device *dev, bool purgeable_only); ...@@ -1157,19 +1158,20 @@ int i915_gem_evict_inactive(struct drm_device *dev, bool purgeable_only);
/* i915_gem_tiling.c */ /* i915_gem_tiling.c */
void i915_gem_detect_bit_6_swizzle(struct drm_device *dev); void i915_gem_detect_bit_6_swizzle(struct drm_device *dev);
void i915_gem_object_do_bit_17_swizzle(struct drm_gem_object *obj); void i915_gem_object_do_bit_17_swizzle(struct drm_i915_gem_object *obj);
void i915_gem_object_save_bit_17_swizzle(struct drm_gem_object *obj); void i915_gem_object_save_bit_17_swizzle(struct drm_i915_gem_object *obj);
/* i915_gem_debug.c */ /* i915_gem_debug.c */
void i915_gem_dump_object(struct drm_gem_object *obj, int len, void i915_gem_dump_object(struct drm_i915_gem_object *obj, int len,
const char *where, uint32_t mark); const char *where, uint32_t mark);
#if WATCH_LISTS #if WATCH_LISTS
int i915_verify_lists(struct drm_device *dev); int i915_verify_lists(struct drm_device *dev);
#else #else
#define i915_verify_lists(dev) 0 #define i915_verify_lists(dev) 0
#endif #endif
void i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle); void i915_gem_object_check_coherency(struct drm_i915_gem_object *obj,
void i915_gem_dump_object(struct drm_gem_object *obj, int len, int handle);
void i915_gem_dump_object(struct drm_i915_gem_object *obj, int len,
const char *where, uint32_t mark); const char *where, uint32_t mark);
/* i915_debugfs.c */ /* i915_debugfs.c */
...@@ -1251,10 +1253,10 @@ extern void intel_display_print_error_state(struct seq_file *m, ...@@ -1251,10 +1253,10 @@ extern void intel_display_print_error_state(struct seq_file *m,
* In that case, we don't need to do it when GEM is initialized as nobody else * In that case, we don't need to do it when GEM is initialized as nobody else
* has access to the ring. * has access to the ring.
*/ */
#define RING_LOCK_TEST_WITH_RETURN(dev, file_priv) do { \ #define RING_LOCK_TEST_WITH_RETURN(dev, file) do { \
if (((drm_i915_private_t *)dev->dev_private)->render_ring.gem_object \ if (((drm_i915_private_t *)dev->dev_private)->render_ring.obj \
== NULL) \ == NULL) \
LOCK_TEST_WITH_RETURN(dev, file_priv); \ LOCK_TEST_WITH_RETURN(dev, file); \
} while (0) } while (0)
......
drivers/gpu/drm/i915/i915_gem.c
View file @ 05394f39
This source diff could not be displayed because it is too large. You can view the blob instead.
drivers/gpu/drm/i915/i915_gem_debug.c
View file @ 05394f39
...@@ -152,13 +152,12 @@ i915_gem_dump_page(struct page *page, uint32_t start, uint32_t end, ...@@ -152,13 +152,12 @@ i915_gem_dump_page(struct page *page, uint32_t start, uint32_t end,
} }
void void
i915_gem_dump_object(struct drm_gem_object *obj, int len, i915_gem_dump_object(struct drm_i915_gem_object *obj, int len,
const char *where, uint32_t mark) const char *where, uint32_t mark)
{ {
struct drm_i915_gem_object *obj_priv = to_intel_bo(obj);
int page; int page;
DRM_INFO("%s: object at offset %08x\n", where, obj_priv->gtt_offset); DRM_INFO("%s: object at offset %08x\n", where, obj->gtt_offset);
for (page = 0; page < (len + PAGE_SIZE-1) / PAGE_SIZE; page++) { for (page = 0; page < (len + PAGE_SIZE-1) / PAGE_SIZE; page++) {
int page_len, chunk, chunk_len; int page_len, chunk, chunk_len;
...@@ -170,9 +169,9 @@ i915_gem_dump_object(struct drm_gem_object *obj, int len, ...@@ -170,9 +169,9 @@ i915_gem_dump_object(struct drm_gem_object *obj, int len,
chunk_len = page_len - chunk; chunk_len = page_len - chunk;
if (chunk_len > 128) if (chunk_len > 128)
chunk_len = 128; chunk_len = 128;
i915_gem_dump_page(obj_priv->pages[page], i915_gem_dump_page(obj->pages[page],
chunk, chunk + chunk_len, chunk, chunk + chunk_len,
obj_priv->gtt_offset + obj->gtt_offset +
page * PAGE_SIZE, page * PAGE_SIZE,
mark); mark);
} }
...@@ -182,21 +181,19 @@ i915_gem_dump_object(struct drm_gem_object *obj, int len, ...@@ -182,21 +181,19 @@ i915_gem_dump_object(struct drm_gem_object *obj, int len,
#if WATCH_COHERENCY #if WATCH_COHERENCY
void void
i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle) i915_gem_object_check_coherency(struct drm_i915_gem_object *obj, int handle)
{ {
struct drm_device *dev = obj->dev; struct drm_device *dev = obj->base.dev;
struct drm_i915_gem_object *obj_priv = to_intel_bo(obj);
int page; int page;
uint32_t *gtt_mapping; uint32_t *gtt_mapping;
uint32_t *backing_map = NULL; uint32_t *backing_map = NULL;
int bad_count = 0; int bad_count = 0;
DRM_INFO("%s: checking coherency of object %p@0x%08x (%d, %zdkb):\n", DRM_INFO("%s: checking coherency of object %p@0x%08x (%d, %zdkb):\n",
__func__, obj, obj_priv->gtt_offset, handle, __func__, obj, obj->gtt_offset, handle,
obj->size / 1024); obj->size / 1024);
gtt_mapping = ioremap(dev->agp->base + obj_priv->gtt_offset, gtt_mapping = ioremap(dev->agp->base + obj->gtt_offset, obj->base.size);
obj->size);
if (gtt_mapping == NULL) { if (gtt_mapping == NULL) {
DRM_ERROR("failed to map GTT space\n"); DRM_ERROR("failed to map GTT space\n");
return; return;
...@@ -205,7 +202,7 @@ i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle) ...@@ -205,7 +202,7 @@ i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle)
for (page = 0; page < obj->size / PAGE_SIZE; page++) { for (page = 0; page < obj->size / PAGE_SIZE; page++) {
int i; int i;
backing_map = kmap_atomic(obj_priv->pages[page], KM_USER0); backing_map = kmap_atomic(obj->pages[page], KM_USER0);
if (backing_map == NULL) { if (backing_map == NULL) {
DRM_ERROR("failed to map backing page\n"); DRM_ERROR("failed to map backing page\n");
...@@ -220,7 +217,7 @@ i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle) ...@@ -220,7 +217,7 @@ i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle)
if (cpuval != gttval) { if (cpuval != gttval) {
DRM_INFO("incoherent CPU vs GPU at 0x%08x: " DRM_INFO("incoherent CPU vs GPU at 0x%08x: "
"0x%08x vs 0x%08x\n", "0x%08x vs 0x%08x\n",
(int)(obj_priv->gtt_offset + (int)(obj->gtt_offset +
page * PAGE_SIZE + i * 4), page * PAGE_SIZE + i * 4),
cpuval, gttval); cpuval, gttval);
if (bad_count++ >= 8) { if (bad_count++ >= 8) {
......
drivers/gpu/drm/i915/i915_gem_evict.c
View file @ 05394f39
...@@ -32,12 +32,11 @@ ...@@ -32,12 +32,11 @@
#include "i915_drm.h" #include "i915_drm.h"
static bool static bool
mark_free(struct drm_i915_gem_object *obj_priv, mark_free(struct drm_i915_gem_object *obj, struct list_head *unwind)
struct list_head *unwind)
{ {
list_add(&obj_priv->evict_list, unwind); list_add(&obj->evict_list, unwind);
drm_gem_object_reference(&obj_priv->base); drm_gem_object_reference(&obj->base);
return drm_mm_scan_add_block(obj_priv->gtt_space); return drm_mm_scan_add_block(obj->gtt_space);
} }
int int
...@@ -46,7 +45,7 @@ i915_gem_evict_something(struct drm_device *dev, int min_size, ...@@ -46,7 +45,7 @@ i915_gem_evict_something(struct drm_device *dev, int min_size,
{ {
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct list_head eviction_list, unwind_list; struct list_head eviction_list, unwind_list;
struct drm_i915_gem_object *obj_priv; struct drm_i915_gem_object *obj;
int ret = 0; int ret = 0;
i915_gem_retire_requests(dev); i915_gem_retire_requests(dev);
...@@ -96,42 +95,42 @@ i915_gem_evict_something(struct drm_device *dev, int min_size, ...@@ -96,42 +95,42 @@ i915_gem_evict_something(struct drm_device *dev, int min_size,
drm_mm_init_scan(&dev_priv->mm.gtt_space, min_size, alignment); drm_mm_init_scan(&dev_priv->mm.gtt_space, min_size, alignment);
/* First see if there is a large enough contiguous idle region... */ /* First see if there is a large enough contiguous idle region... */
list_for_each_entry(obj_priv, &dev_priv->mm.inactive_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.inactive_list, mm_list) {
if (mark_free(obj_priv, &unwind_list)) if (mark_free(obj, &unwind_list))
goto found; goto found;
} }
/* Now merge in the soon-to-be-expired objects... */ /* Now merge in the soon-to-be-expired objects... */
list_for_each_entry(obj_priv, &dev_priv->mm.active_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.active_list, mm_list) {
/* Does the object require an outstanding flush? */ /* Does the object require an outstanding flush? */
if (obj_priv->base.write_domain || obj_priv->pin_count) if (obj->base.write_domain || obj->pin_count)
continue; continue;
if (mark_free(obj_priv, &unwind_list)) if (mark_free(obj, &unwind_list))
goto found; goto found;
} }
/* Finally add anything with a pending flush (in order of retirement) */ /* Finally add anything with a pending flush (in order of retirement) */
list_for_each_entry(obj_priv, &dev_priv->mm.flushing_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.flushing_list, mm_list) {
if (obj_priv->pin_count) if (obj->pin_count)
continue; continue;
if (mark_free(obj_priv, &unwind_list)) if (mark_free(obj, &unwind_list))
goto found; goto found;
} }
list_for_each_entry(obj_priv, &dev_priv->mm.active_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.active_list, mm_list) {
if (! obj_priv->base.write_domain || obj_priv->pin_count) if (! obj->base.write_domain || obj->pin_count)
continue; continue;
if (mark_free(obj_priv, &unwind_list)) if (mark_free(obj, &unwind_list))
goto found; goto found;
} }
/* Nothing found, clean up and bail out! */ /* Nothing found, clean up and bail out! */
list_for_each_entry(obj_priv, &unwind_list, evict_list) { list_for_each_entry(obj, &unwind_list, evict_list) {
ret = drm_mm_scan_remove_block(obj_priv->gtt_space); ret = drm_mm_scan_remove_block(obj->gtt_space);
BUG_ON(ret); BUG_ON(ret);
drm_gem_object_unreference(&obj_priv->base); drm_gem_object_unreference(&obj->base);
} }
/* We expect the caller to unpin, evict all and try again, or give up. /* We expect the caller to unpin, evict all and try again, or give up.
...@@ -145,26 +144,26 @@ i915_gem_evict_something(struct drm_device *dev, int min_size, ...@@ -145,26 +144,26 @@ i915_gem_evict_something(struct drm_device *dev, int min_size,
* temporary list. */ * temporary list. */
INIT_LIST_HEAD(&eviction_list); INIT_LIST_HEAD(&eviction_list);
while (!list_empty(&unwind_list)) { while (!list_empty(&unwind_list)) {
obj_priv = list_first_entry(&unwind_list, obj = list_first_entry(&unwind_list,
struct drm_i915_gem_object, struct drm_i915_gem_object,
evict_list); evict_list);
if (drm_mm_scan_remove_block(obj_priv->gtt_space)) { if (drm_mm_scan_remove_block(obj->gtt_space)) {
list_move(&obj_priv->evict_list, &eviction_list); list_move(&obj->evict_list, &eviction_list);
continue; continue;
} }
list_del(&obj_priv->evict_list); list_del(&obj->evict_list);
drm_gem_object_unreference(&obj_priv->base); drm_gem_object_unreference(&obj->base);
} }
/* Unbinding will emit any required flushes */ /* Unbinding will emit any required flushes */
while (!list_empty(&eviction_list)) { while (!list_empty(&eviction_list)) {
obj_priv = list_first_entry(&eviction_list, obj = list_first_entry(&eviction_list,
struct drm_i915_gem_object, struct drm_i915_gem_object,
evict_list); evict_list);
if (ret == 0) if (ret == 0)
ret = i915_gem_object_unbind(&obj_priv->base); ret = i915_gem_object_unbind(obj);
list_del(&obj_priv->evict_list); list_del(&obj->evict_list);
drm_gem_object_unreference(&obj_priv->base); drm_gem_object_unreference(&obj->base);
} }
return ret; return ret;
...@@ -203,7 +202,7 @@ i915_gem_evict_inactive(struct drm_device *dev, bool purgeable_only) ...@@ -203,7 +202,7 @@ i915_gem_evict_inactive(struct drm_device *dev, bool purgeable_only)
list_for_each_entry_safe(obj, next, list_for_each_entry_safe(obj, next,
&dev_priv->mm.inactive_list, mm_list) { &dev_priv->mm.inactive_list, mm_list) {
if (!purgeable_only || obj->madv != I915_MADV_WILLNEED) { if (!purgeable_only || obj->madv != I915_MADV_WILLNEED) {
int ret = i915_gem_object_unbind(&obj->base); int ret = i915_gem_object_unbind(obj);
if (ret) if (ret)
return ret; return ret;
} }
......
drivers/gpu/drm/i915/i915_gem_gtt.c
View file @ 05394f39
...@@ -32,71 +32,67 @@ ...@@ -32,71 +32,67 @@
void i915_gem_restore_gtt_mappings(struct drm_device *dev) void i915_gem_restore_gtt_mappings(struct drm_device *dev)
{ {
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj_priv; struct drm_i915_gem_object *obj;
list_for_each_entry(obj_priv, list_for_each_entry(obj, &dev_priv->mm.gtt_list, gtt_list) {
&dev_priv->mm.gtt_list,
gtt_list) {
if (dev_priv->mm.gtt->needs_dmar) { if (dev_priv->mm.gtt->needs_dmar) {
BUG_ON(!obj_priv->sg_list); BUG_ON(!obj->sg_list);
intel_gtt_insert_sg_entries(obj_priv->sg_list, intel_gtt_insert_sg_entries(obj->sg_list,
obj_priv->num_sg, obj->num_sg,
obj_priv->gtt_space->start obj->gtt_space->start
>> PAGE_SHIFT, >> PAGE_SHIFT,
obj_priv->agp_type); obj->agp_type);
} else } else
intel_gtt_insert_pages(obj_priv->gtt_space->start intel_gtt_insert_pages(obj->gtt_space->start
>> PAGE_SHIFT, >> PAGE_SHIFT,
obj_priv->base.size >> PAGE_SHIFT, obj->base.size >> PAGE_SHIFT,
obj_priv->pages, obj->pages,
obj_priv->agp_type); obj->agp_type);
} }
/* Be paranoid and flush the chipset cache. */ /* Be paranoid and flush the chipset cache. */
intel_gtt_chipset_flush(); intel_gtt_chipset_flush();
} }
int i915_gem_gtt_bind_object(struct drm_gem_object *obj) int i915_gem_gtt_bind_object(struct drm_i915_gem_object *obj)
{ {
struct drm_device *dev = obj->dev; struct drm_device *dev = obj->base.dev;
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj_priv = to_intel_bo(obj);
int ret; int ret;
if (dev_priv->mm.gtt->needs_dmar) { if (dev_priv->mm.gtt->needs_dmar) {
ret = intel_gtt_map_memory(obj_priv->pages, ret = intel_gtt_map_memory(obj->pages,
obj->size >> PAGE_SHIFT, obj->base.size >> PAGE_SHIFT,
&obj_priv->sg_list, &obj->sg_list,
&obj_priv->num_sg); &obj->num_sg);
if (ret != 0) if (ret != 0)
return ret; return ret;
intel_gtt_insert_sg_entries(obj_priv->sg_list, obj_priv->num_sg, intel_gtt_insert_sg_entries(obj->sg_list,
obj_priv->gtt_space->start obj->num_sg,
>> PAGE_SHIFT, obj->gtt_space->start >> PAGE_SHIFT,
obj_priv->agp_type); obj->agp_type);
} else } else
intel_gtt_insert_pages(obj_priv->gtt_space->start >> PAGE_SHIFT, intel_gtt_insert_pages(obj->gtt_space->start >> PAGE_SHIFT,
obj->size >> PAGE_SHIFT, obj->base.size >> PAGE_SHIFT,
obj_priv->pages, obj->pages,
obj_priv->agp_type); obj->agp_type);
return 0; return 0;
} }
void i915_gem_gtt_unbind_object(struct drm_gem_object *obj) void i915_gem_gtt_unbind_object(struct drm_i915_gem_object *obj)
{ {
struct drm_device *dev = obj->dev; struct drm_device *dev = obj->base.dev;
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj_priv = to_intel_bo(obj);
if (dev_priv->mm.gtt->needs_dmar) { if (dev_priv->mm.gtt->needs_dmar) {
intel_gtt_unmap_memory(obj_priv->sg_list, obj_priv->num_sg); intel_gtt_unmap_memory(obj->sg_list, obj->num_sg);
obj_priv->sg_list = NULL; obj->sg_list = NULL;
obj_priv->num_sg = 0; obj->num_sg = 0;
} }
intel_gtt_clear_range(obj_priv->gtt_space->start >> PAGE_SHIFT, intel_gtt_clear_range(obj->gtt_space->start >> PAGE_SHIFT,
obj->size >> PAGE_SHIFT); obj->base.size >> PAGE_SHIFT);
} }
drivers/gpu/drm/i915/i915_gem_tiling.c
View file @ 05394f39
...@@ -234,25 +234,24 @@ i915_tiling_ok(struct drm_device *dev, int stride, int size, int tiling_mode) ...@@ -234,25 +234,24 @@ i915_tiling_ok(struct drm_device *dev, int stride, int size, int tiling_mode)
/* Is the current GTT allocation valid for the change in tiling? */ /* Is the current GTT allocation valid for the change in tiling? */
static bool static bool
i915_gem_object_fence_ok(struct drm_gem_object *obj, int tiling_mode) i915_gem_object_fence_ok(struct drm_i915_gem_object *obj, int tiling_mode)
{ {
struct drm_i915_gem_object *obj_priv = to_intel_bo(obj);
u32 size; u32 size;
if (tiling_mode == I915_TILING_NONE) if (tiling_mode == I915_TILING_NONE)
return true; return true;
if (INTEL_INFO(obj->dev)->gen >= 4) if (INTEL_INFO(obj->base.dev)->gen >= 4)
return true; return true;
if (!obj_priv->gtt_space) if (!obj->gtt_space)
return true; return true;
if (INTEL_INFO(obj->dev)->gen == 3) { if (INTEL_INFO(obj->base.dev)->gen == 3) {
if (obj_priv->gtt_offset & ~I915_FENCE_START_MASK) if (obj->gtt_offset & ~I915_FENCE_START_MASK)
return false; return false;
} else { } else {
if (obj_priv->gtt_offset & ~I830_FENCE_START_MASK) if (obj->gtt_offset & ~I830_FENCE_START_MASK)
return false; return false;
} }
...@@ -260,18 +259,18 @@ i915_gem_object_fence_ok(struct drm_gem_object *obj, int tiling_mode) ...@@ -260,18 +259,18 @@ i915_gem_object_fence_ok(struct drm_gem_object *obj, int tiling_mode)
* Previous chips need to be aligned to the size of the smallest * Previous chips need to be aligned to the size of the smallest
* fence register that can contain the object. * fence register that can contain the object.
*/ */
if (INTEL_INFO(obj->dev)->gen == 3) if (INTEL_INFO(obj->base.dev)->gen == 3)
size = 1024*1024; size = 1024*1024;
else else
size = 512*1024; size = 512*1024;
while (size < obj_priv->base.size) while (size < obj->base.size)
size <<= 1; size <<= 1;
if (obj_priv->gtt_space->size != size) if (obj->gtt_space->size != size)
return false; return false;
if (obj_priv->gtt_offset & (size - 1)) if (obj->gtt_offset & (size - 1))
return false; return false;
return true; return true;
...@@ -283,30 +282,29 @@ i915_gem_object_fence_ok(struct drm_gem_object *obj, int tiling_mode) ...@@ -283,30 +282,29 @@ i915_gem_object_fence_ok(struct drm_gem_object *obj, int tiling_mode)
*/ */
int int
i915_gem_set_tiling(struct drm_device *dev, void *data, i915_gem_set_tiling(struct drm_device *dev, void *data,
struct drm_file *file_priv) struct drm_file *file)
{ {
struct drm_i915_gem_set_tiling *args = data; struct drm_i915_gem_set_tiling *args = data;
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_gem_object *obj; struct drm_i915_gem_object *obj;
struct drm_i915_gem_object *obj_priv;
int ret; int ret;
ret = i915_gem_check_is_wedged(dev); ret = i915_gem_check_is_wedged(dev);
if (ret) if (ret)
return ret; return ret;
obj = drm_gem_object_lookup(dev, file_priv, args->handle); obj = to_intel_bo(drm_gem_object_lookup(dev, file, args->handle));
if (obj == NULL) if (obj == NULL)
return -ENOENT; return -ENOENT;
obj_priv = to_intel_bo(obj);
if (!i915_tiling_ok(dev, args->stride, obj->size, args->tiling_mode)) { if (!i915_tiling_ok(dev,
drm_gem_object_unreference_unlocked(obj); args->stride, obj->base.size, args->tiling_mode)) {
drm_gem_object_unreference_unlocked(&obj->base);
return -EINVAL; return -EINVAL;
} }
if (obj_priv->pin_count) { if (obj->pin_count) {
drm_gem_object_unreference_unlocked(obj); drm_gem_object_unreference_unlocked(&obj->base);
return -EBUSY; return -EBUSY;
} }
...@@ -340,8 +338,8 @@ i915_gem_set_tiling(struct drm_device *dev, void *data, ...@@ -340,8 +338,8 @@ i915_gem_set_tiling(struct drm_device *dev, void *data,
} }
mutex_lock(&dev->struct_mutex); mutex_lock(&dev->struct_mutex);
if (args->tiling_mode != obj_priv->tiling_mode || if (args->tiling_mode != obj->tiling_mode ||
args->stride != obj_priv->stride) { args->stride != obj->stride) {
/* We need to rebind the object if its current allocation /* We need to rebind the object if its current allocation
* no longer meets the alignment restrictions for its new * no longer meets the alignment restrictions for its new
* tiling mode. Otherwise we can just leave it alone, but * tiling mode. Otherwise we can just leave it alone, but
...@@ -349,22 +347,22 @@ i915_gem_set_tiling(struct drm_device *dev, void *data, ...@@ -349,22 +347,22 @@ i915_gem_set_tiling(struct drm_device *dev, void *data,
*/ */
if (!i915_gem_object_fence_ok(obj, args->tiling_mode)) if (!i915_gem_object_fence_ok(obj, args->tiling_mode))
ret = i915_gem_object_unbind(obj); ret = i915_gem_object_unbind(obj);
else if (obj_priv->fence_reg != I915_FENCE_REG_NONE) else if (obj->fence_reg != I915_FENCE_REG_NONE)
ret = i915_gem_object_put_fence_reg(obj, true); ret = i915_gem_object_put_fence_reg(obj, true);
else else
i915_gem_release_mmap(obj); i915_gem_release_mmap(obj);
if (ret != 0) { if (ret != 0) {
args->tiling_mode = obj_priv->tiling_mode; args->tiling_mode = obj->tiling_mode;
args->stride = obj_priv->stride; args->stride = obj->stride;
goto err; goto err;
} }
obj_priv->tiling_mode = args->tiling_mode; obj->tiling_mode = args->tiling_mode;
obj_priv->stride = args->stride; obj->stride = args->stride;
} }
err: err:
drm_gem_object_unreference(obj); drm_gem_object_unreference(&obj->base);
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
return ret; return ret;
...@@ -375,22 +373,20 @@ i915_gem_set_tiling(struct drm_device *dev, void *data, ...@@ -375,22 +373,20 @@ i915_gem_set_tiling(struct drm_device *dev, void *data,
*/ */
int int
i915_gem_get_tiling(struct drm_device *dev, void *data, i915_gem_get_tiling(struct drm_device *dev, void *data,
struct drm_file *file_priv) struct drm_file *file)
{ {
struct drm_i915_gem_get_tiling *args = data; struct drm_i915_gem_get_tiling *args = data;
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_gem_object *obj; struct drm_i915_gem_object *obj;
struct drm_i915_gem_object *obj_priv;
obj = drm_gem_object_lookup(dev, file_priv, args->handle); obj = to_intel_bo(drm_gem_object_lookup(dev, file, args->handle));
if (obj == NULL) if (obj == NULL)
return -ENOENT; return -ENOENT;
obj_priv = to_intel_bo(obj);
mutex_lock(&dev->struct_mutex); mutex_lock(&dev->struct_mutex);
args->tiling_mode = obj_priv->tiling_mode; args->tiling_mode = obj->tiling_mode;
switch (obj_priv->tiling_mode) { switch (obj->tiling_mode) {
case I915_TILING_X: case I915_TILING_X:
args->swizzle_mode = dev_priv->mm.bit_6_swizzle_x; args->swizzle_mode = dev_priv->mm.bit_6_swizzle_x;
break; break;
...@@ -410,7 +406,7 @@ i915_gem_get_tiling(struct drm_device *dev, void *data, ...@@ -410,7 +406,7 @@ i915_gem_get_tiling(struct drm_device *dev, void *data,
if (args->swizzle_mode == I915_BIT_6_SWIZZLE_9_10_17) if (args->swizzle_mode == I915_BIT_6_SWIZZLE_9_10_17)
args->swizzle_mode = I915_BIT_6_SWIZZLE_9_10; args->swizzle_mode = I915_BIT_6_SWIZZLE_9_10;
drm_gem_object_unreference(obj); drm_gem_object_unreference(&obj->base);
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
return 0; return 0;
...@@ -440,46 +436,44 @@ i915_gem_swizzle_page(struct page *page) ...@@ -440,46 +436,44 @@ i915_gem_swizzle_page(struct page *page)
} }
void void
i915_gem_object_do_bit_17_swizzle(struct drm_gem_object *obj) i915_gem_object_do_bit_17_swizzle(struct drm_i915_gem_object *obj)
{ {
struct drm_device *dev = obj->dev; struct drm_device *dev = obj->base.dev;
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj_priv = to_intel_bo(obj); int page_count = obj->base.size >> PAGE_SHIFT;
int page_count = obj->size >> PAGE_SHIFT;
int i; int i;
if (dev_priv->mm.bit_6_swizzle_x != I915_BIT_6_SWIZZLE_9_10_17) if (dev_priv->mm.bit_6_swizzle_x != I915_BIT_6_SWIZZLE_9_10_17)
return; return;
if (obj_priv->bit_17 == NULL) if (obj->bit_17 == NULL)
return; return;
for (i = 0; i < page_count; i++) { for (i = 0; i < page_count; i++) {
char new_bit_17 = page_to_phys(obj_priv->pages[i]) >> 17; char new_bit_17 = page_to_phys(obj->pages[i]) >> 17;
if ((new_bit_17 & 0x1) != if ((new_bit_17 & 0x1) !=
(test_bit(i, obj_priv->bit_17) != 0)) { (test_bit(i, obj->bit_17) != 0)) {
i915_gem_swizzle_page(obj_priv->pages[i]); i915_gem_swizzle_page(obj->pages[i]);
set_page_dirty(obj_priv->pages[i]); set_page_dirty(obj->pages[i]);
} }
} }
} }
void void
i915_gem_object_save_bit_17_swizzle(struct drm_gem_object *obj) i915_gem_object_save_bit_17_swizzle(struct drm_i915_gem_object *obj)
{ {
struct drm_device *dev = obj->dev; struct drm_device *dev = obj->base.dev;
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj_priv = to_intel_bo(obj); int page_count = obj->base.size >> PAGE_SHIFT;
int page_count = obj->size >> PAGE_SHIFT;
int i; int i;
if (dev_priv->mm.bit_6_swizzle_x != I915_BIT_6_SWIZZLE_9_10_17) if (dev_priv->mm.bit_6_swizzle_x != I915_BIT_6_SWIZZLE_9_10_17)
return; return;
if (obj_priv->bit_17 == NULL) { if (obj->bit_17 == NULL) {
obj_priv->bit_17 = kmalloc(BITS_TO_LONGS(page_count) * obj->bit_17 = kmalloc(BITS_TO_LONGS(page_count) *
sizeof(long), GFP_KERNEL); sizeof(long), GFP_KERNEL);
if (obj_priv->bit_17 == NULL) { if (obj->bit_17 == NULL) {
DRM_ERROR("Failed to allocate memory for bit 17 " DRM_ERROR("Failed to allocate memory for bit 17 "
"record\n"); "record\n");
return; return;
...@@ -487,9 +481,9 @@ i915_gem_object_save_bit_17_swizzle(struct drm_gem_object *obj) ...@@ -487,9 +481,9 @@ i915_gem_object_save_bit_17_swizzle(struct drm_gem_object *obj)
} }
for (i = 0; i < page_count; i++) { for (i = 0; i < page_count; i++) {
if (page_to_phys(obj_priv->pages[i]) & (1 << 17)) if (page_to_phys(obj->pages[i]) & (1 << 17))
__set_bit(i, obj_priv->bit_17); __set_bit(i, obj->bit_17);
else else
__clear_bit(i, obj_priv->bit_17); __clear_bit(i, obj->bit_17);
} }
} }
drivers/gpu/drm/i915/i915_irq.c
View file @ 05394f39
...@@ -423,28 +423,23 @@ static void i915_error_work_func(struct work_struct *work) ...@@ -423,28 +423,23 @@ static void i915_error_work_func(struct work_struct *work)
#ifdef CONFIG_DEBUG_FS #ifdef CONFIG_DEBUG_FS
static struct drm_i915_error_object * static struct drm_i915_error_object *
i915_error_object_create(struct drm_device *dev, i915_error_object_create(struct drm_device *dev,
struct drm_gem_object *src) struct drm_i915_gem_object *src)
{ {
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_i915_error_object *dst; struct drm_i915_error_object *dst;
struct drm_i915_gem_object *src_priv;
int page, page_count; int page, page_count;
u32 reloc_offset; u32 reloc_offset;
if (src == NULL) if (src == NULL || src->pages == NULL)
return NULL; return NULL;
src_priv = to_intel_bo(src); page_count = src->base.size / PAGE_SIZE;
if (src_priv->pages == NULL)
return NULL;
page_count = src->size / PAGE_SIZE;
dst = kmalloc(sizeof(*dst) + page_count * sizeof (u32 *), GFP_ATOMIC); dst = kmalloc(sizeof(*dst) + page_count * sizeof (u32 *), GFP_ATOMIC);
if (dst == NULL) if (dst == NULL)
return NULL; return NULL;
reloc_offset = src_priv->gtt_offset; reloc_offset = src->gtt_offset;
for (page = 0; page < page_count; page++) { for (page = 0; page < page_count; page++) {
unsigned long flags; unsigned long flags;
void __iomem *s; void __iomem *s;
...@@ -466,7 +461,7 @@ i915_error_object_create(struct drm_device *dev, ...@@ -466,7 +461,7 @@ i915_error_object_create(struct drm_device *dev,
reloc_offset += PAGE_SIZE; reloc_offset += PAGE_SIZE;
} }
dst->page_count = page_count; dst->page_count = page_count;
dst->gtt_offset = src_priv->gtt_offset; dst->gtt_offset = src->gtt_offset;
return dst; return dst;
...@@ -598,9 +593,9 @@ static u32 capture_bo_list(struct drm_i915_error_buffer *err, ...@@ -598,9 +593,9 @@ static u32 capture_bo_list(struct drm_i915_error_buffer *err,
static void i915_capture_error_state(struct drm_device *dev) static void i915_capture_error_state(struct drm_device *dev)
{ {
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
struct drm_i915_gem_object *obj_priv; struct drm_i915_gem_object *obj;
struct drm_i915_error_state *error; struct drm_i915_error_state *error;
struct drm_gem_object *batchbuffer[2]; struct drm_i915_gem_object *batchbuffer[2];
unsigned long flags; unsigned long flags;
u32 bbaddr; u32 bbaddr;
int count; int count;
...@@ -668,34 +663,30 @@ static void i915_capture_error_state(struct drm_device *dev) ...@@ -668,34 +663,30 @@ static void i915_capture_error_state(struct drm_device *dev)
batchbuffer[0] = NULL; batchbuffer[0] = NULL;
batchbuffer[1] = NULL; batchbuffer[1] = NULL;
count = 0; count = 0;
list_for_each_entry(obj_priv, &dev_priv->mm.active_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.active_list, mm_list) {
struct drm_gem_object *obj = &obj_priv->base;
if (batchbuffer[0] == NULL && if (batchbuffer[0] == NULL &&
bbaddr >= obj_priv->gtt_offset && bbaddr >= obj->gtt_offset &&
bbaddr < obj_priv->gtt_offset + obj->size) bbaddr < obj->gtt_offset + obj->base.size)
batchbuffer[0] = obj; batchbuffer[0] = obj;
if (batchbuffer[1] == NULL && if (batchbuffer[1] == NULL &&
error->acthd >= obj_priv->gtt_offset && error->acthd >= obj->gtt_offset &&
error->acthd < obj_priv->gtt_offset + obj->size) error->acthd < obj->gtt_offset + obj->base.size)
batchbuffer[1] = obj; batchbuffer[1] = obj;
count++; count++;
} }
/* Scan the other lists for completeness for those bizarre errors. */ /* Scan the other lists for completeness for those bizarre errors. */
if (batchbuffer[0] == NULL || batchbuffer[1] == NULL) { if (batchbuffer[0] == NULL || batchbuffer[1] == NULL) {
list_for_each_entry(obj_priv, &dev_priv->mm.flushing_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.flushing_list, mm_list) {
struct drm_gem_object *obj = &obj_priv->base;
if (batchbuffer[0] == NULL && if (batchbuffer[0] == NULL &&
bbaddr >= obj_priv->gtt_offset && bbaddr >= obj->gtt_offset &&
bbaddr < obj_priv->gtt_offset + obj->size) bbaddr < obj->gtt_offset + obj->base.size)
batchbuffer[0] = obj; batchbuffer[0] = obj;
if (batchbuffer[1] == NULL && if (batchbuffer[1] == NULL &&
error->acthd >= obj_priv->gtt_offset && error->acthd >= obj->gtt_offset &&
error->acthd < obj_priv->gtt_offset + obj->size) error->acthd < obj->gtt_offset + obj->base.size)
batchbuffer[1] = obj; batchbuffer[1] = obj;
if (batchbuffer[0] && batchbuffer[1]) if (batchbuffer[0] && batchbuffer[1])
...@@ -703,17 +694,15 @@ static void i915_capture_error_state(struct drm_device *dev) ...@@ -703,17 +694,15 @@ static void i915_capture_error_state(struct drm_device *dev)
} }
} }
if (batchbuffer[0] == NULL || batchbuffer[1] == NULL) { if (batchbuffer[0] == NULL || batchbuffer[1] == NULL) {
list_for_each_entry(obj_priv, &dev_priv->mm.inactive_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.inactive_list, mm_list) {
struct drm_gem_object *obj = &obj_priv->base;
if (batchbuffer[0] == NULL && if (batchbuffer[0] == NULL &&
bbaddr >= obj_priv->gtt_offset && bbaddr >= obj->gtt_offset &&
bbaddr < obj_priv->gtt_offset + obj->size) bbaddr < obj->gtt_offset + obj->base.size)
batchbuffer[0] = obj; batchbuffer[0] = obj;
if (batchbuffer[1] == NULL && if (batchbuffer[1] == NULL &&
error->acthd >= obj_priv->gtt_offset && error->acthd >= obj->gtt_offset &&
error->acthd < obj_priv->gtt_offset + obj->size) error->acthd < obj->gtt_offset + obj->base.size)
batchbuffer[1] = obj; batchbuffer[1] = obj;
if (batchbuffer[0] && batchbuffer[1]) if (batchbuffer[0] && batchbuffer[1])
...@@ -732,14 +721,14 @@ static void i915_capture_error_state(struct drm_device *dev) ...@@ -732,14 +721,14 @@ static void i915_capture_error_state(struct drm_device *dev)
/* Record the ringbuffer */ /* Record the ringbuffer */
error->ringbuffer = i915_error_object_create(dev, error->ringbuffer = i915_error_object_create(dev,
dev_priv->render_ring.gem_object); dev_priv->render_ring.obj);
/* Record buffers on the active and pinned lists. */ /* Record buffers on the active and pinned lists. */
error->active_bo = NULL; error->active_bo = NULL;
error->pinned_bo = NULL; error->pinned_bo = NULL;
error->active_bo_count = count; error->active_bo_count = count;
list_for_each_entry(obj_priv, &dev_priv->mm.pinned_list, mm_list) list_for_each_entry(obj, &dev_priv->mm.pinned_list, mm_list)
count++; count++;
error->pinned_bo_count = count - error->active_bo_count; error->pinned_bo_count = count - error->active_bo_count;
...@@ -948,7 +937,7 @@ static void i915_pageflip_stall_check(struct drm_device *dev, int pipe) ...@@ -948,7 +937,7 @@ static void i915_pageflip_stall_check(struct drm_device *dev, int pipe)
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_crtc *crtc = dev_priv->pipe_to_crtc_mapping[pipe]; struct drm_crtc *crtc = dev_priv->pipe_to_crtc_mapping[pipe];
struct intel_crtc *intel_crtc = to_intel_crtc(crtc); struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
struct drm_i915_gem_object *obj_priv; struct drm_i915_gem_object *obj;
struct intel_unpin_work *work; struct intel_unpin_work *work;
unsigned long flags; unsigned long flags;
bool stall_detected; bool stall_detected;
...@@ -967,13 +956,13 @@ static void i915_pageflip_stall_check(struct drm_device *dev, int pipe) ...@@ -967,13 +956,13 @@ static void i915_pageflip_stall_check(struct drm_device *dev, int pipe)
} }
/* Potential stall - if we see that the flip has happened, assume a missed interrupt */ /* Potential stall - if we see that the flip has happened, assume a missed interrupt */
obj_priv = to_intel_bo(work->pending_flip_obj); obj = work->pending_flip_obj;
if (INTEL_INFO(dev)->gen >= 4) { if (INTEL_INFO(dev)->gen >= 4) {
int dspsurf = intel_crtc->plane == 0 ? DSPASURF : DSPBSURF; int dspsurf = intel_crtc->plane == 0 ? DSPASURF : DSPBSURF;
stall_detected = I915_READ(dspsurf) == obj_priv->gtt_offset; stall_detected = I915_READ(dspsurf) == obj->gtt_offset;
} else { } else {
int dspaddr = intel_crtc->plane == 0 ? DSPAADDR : DSPBADDR; int dspaddr = intel_crtc->plane == 0 ? DSPAADDR : DSPBADDR;
stall_detected = I915_READ(dspaddr) == (obj_priv->gtt_offset + stall_detected = I915_READ(dspaddr) == (obj->gtt_offset +
crtc->y * crtc->fb->pitch + crtc->y * crtc->fb->pitch +
crtc->x * crtc->fb->bits_per_pixel/8); crtc->x * crtc->fb->bits_per_pixel/8);
} }
......
drivers/gpu/drm/i915/i915_trace.h
View file @ 05394f39
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include <linux/tracepoint.h> #include <linux/tracepoint.h>
#include <drm/drmP.h> #include <drm/drmP.h>
#include "i915_drv.h"
#undef TRACE_SYSTEM #undef TRACE_SYSTEM
#define TRACE_SYSTEM i915 #define TRACE_SYSTEM i915
...@@ -16,18 +17,18 @@ ...@@ -16,18 +17,18 @@
TRACE_EVENT(i915_gem_object_create, TRACE_EVENT(i915_gem_object_create,
TP_PROTO(struct drm_gem_object *obj), TP_PROTO(struct drm_i915_gem_object *obj),
TP_ARGS(obj), TP_ARGS(obj),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(struct drm_gem_object *, obj) __field(struct drm_i915_gem_object *, obj)
__field(u32, size) __field(u32, size)
), ),
TP_fast_assign( TP_fast_assign(
__entry->obj = obj; __entry->obj = obj;
__entry->size = obj->size; __entry->size = obj->base.size;
), ),
TP_printk("obj=%p, size=%u", __entry->obj, __entry->size) TP_printk("obj=%p, size=%u", __entry->obj, __entry->size)
...@@ -35,12 +36,12 @@ TRACE_EVENT(i915_gem_object_create, ...@@ -35,12 +36,12 @@ TRACE_EVENT(i915_gem_object_create,
TRACE_EVENT(i915_gem_object_bind, TRACE_EVENT(i915_gem_object_bind,
TP_PROTO(struct drm_gem_object *obj, u32 gtt_offset, bool mappable), TP_PROTO(struct drm_i915_gem_object *obj, u32 gtt_offset, bool mappable),
TP_ARGS(obj, gtt_offset, mappable), TP_ARGS(obj, gtt_offset, mappable),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(struct drm_gem_object *, obj) __field(struct drm_i915_gem_object *, obj)
__field(u32, gtt_offset) __field(u32, gtt_offset)
__field(bool, mappable) __field(bool, mappable)
), ),
...@@ -58,20 +59,20 @@ TRACE_EVENT(i915_gem_object_bind, ...@@ -58,20 +59,20 @@ TRACE_EVENT(i915_gem_object_bind,
TRACE_EVENT(i915_gem_object_change_domain, TRACE_EVENT(i915_gem_object_change_domain,
TP_PROTO(struct drm_gem_object *obj, uint32_t old_read_domains, uint32_t old_write_domain), TP_PROTO(struct drm_i915_gem_object *obj, uint32_t old_read_domains, uint32_t old_write_domain),
TP_ARGS(obj, old_read_domains, old_write_domain), TP_ARGS(obj, old_read_domains, old_write_domain),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(struct drm_gem_object *, obj) __field(struct drm_i915_gem_object *, obj)
__field(u32, read_domains) __field(u32, read_domains)
__field(u32, write_domain) __field(u32, write_domain)
), ),
TP_fast_assign( TP_fast_assign(
__entry->obj = obj; __entry->obj = obj;
__entry->read_domains = obj->read_domains | (old_read_domains << 16); __entry->read_domains = obj->base.read_domains | (old_read_domains << 16);
__entry->write_domain = obj->write_domain | (old_write_domain << 16); __entry->write_domain = obj->base.write_domain | (old_write_domain << 16);
), ),
TP_printk("obj=%p, read=%04x, write=%04x", TP_printk("obj=%p, read=%04x, write=%04x",
...@@ -81,12 +82,12 @@ TRACE_EVENT(i915_gem_object_change_domain, ...@@ -81,12 +82,12 @@ TRACE_EVENT(i915_gem_object_change_domain,
TRACE_EVENT(i915_gem_object_get_fence, TRACE_EVENT(i915_gem_object_get_fence,
TP_PROTO(struct drm_gem_object *obj, int fence, int tiling_mode), TP_PROTO(struct drm_i915_gem_object *obj, int fence, int tiling_mode),
TP_ARGS(obj, fence, tiling_mode), TP_ARGS(obj, fence, tiling_mode),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(struct drm_gem_object *, obj) __field(struct drm_i915_gem_object *, obj)
__field(int, fence) __field(int, fence)
__field(int, tiling_mode) __field(int, tiling_mode)
), ),
...@@ -103,12 +104,12 @@ TRACE_EVENT(i915_gem_object_get_fence, ...@@ -103,12 +104,12 @@ TRACE_EVENT(i915_gem_object_get_fence,
DECLARE_EVENT_CLASS(i915_gem_object, DECLARE_EVENT_CLASS(i915_gem_object,
TP_PROTO(struct drm_gem_object *obj), TP_PROTO(struct drm_i915_gem_object *obj),
TP_ARGS(obj), TP_ARGS(obj),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(struct drm_gem_object *, obj) __field(struct drm_i915_gem_object *, obj)
), ),
TP_fast_assign( TP_fast_assign(
...@@ -120,21 +121,21 @@ DECLARE_EVENT_CLASS(i915_gem_object, ...@@ -120,21 +121,21 @@ DECLARE_EVENT_CLASS(i915_gem_object,
DEFINE_EVENT(i915_gem_object, i915_gem_object_clflush, DEFINE_EVENT(i915_gem_object, i915_gem_object_clflush,
TP_PROTO(struct drm_gem_object *obj), TP_PROTO(struct drm_i915_gem_object *obj),
TP_ARGS(obj) TP_ARGS(obj)
); );
DEFINE_EVENT(i915_gem_object, i915_gem_object_unbind, DEFINE_EVENT(i915_gem_object, i915_gem_object_unbind,
TP_PROTO(struct drm_gem_object *obj), TP_PROTO(struct drm_i915_gem_object *obj),
TP_ARGS(obj) TP_ARGS(obj)
); );
DEFINE_EVENT(i915_gem_object, i915_gem_object_destroy, DEFINE_EVENT(i915_gem_object, i915_gem_object_destroy,
TP_PROTO(struct drm_gem_object *obj), TP_PROTO(struct drm_i915_gem_object *obj),
TP_ARGS(obj) TP_ARGS(obj)
); );
...@@ -266,13 +267,13 @@ DEFINE_EVENT(i915_ring, i915_ring_wait_end, ...@@ -266,13 +267,13 @@ DEFINE_EVENT(i915_ring, i915_ring_wait_end,
); );
TRACE_EVENT(i915_flip_request, TRACE_EVENT(i915_flip_request,
TP_PROTO(int plane, struct drm_gem_object *obj), TP_PROTO(int plane, struct drm_i915_gem_object *obj),
TP_ARGS(plane, obj), TP_ARGS(plane, obj),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(int, plane) __field(int, plane)
__field(struct drm_gem_object *, obj) __field(struct drm_i915_gem_object *, obj)
), ),
TP_fast_assign( TP_fast_assign(
...@@ -284,13 +285,13 @@ TRACE_EVENT(i915_flip_request, ...@@ -284,13 +285,13 @@ TRACE_EVENT(i915_flip_request,
); );
TRACE_EVENT(i915_flip_complete, TRACE_EVENT(i915_flip_complete,
TP_PROTO(int plane, struct drm_gem_object *obj), TP_PROTO(int plane, struct drm_i915_gem_object *obj),
TP_ARGS(plane, obj), TP_ARGS(plane, obj),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(int, plane) __field(int, plane)
__field(struct drm_gem_object *, obj) __field(struct drm_i915_gem_object *, obj)
), ),
TP_fast_assign( TP_fast_assign(
......
drivers/gpu/drm/i915/intel_display.c
View file @ 05394f39
This diff is collapsed.
drivers/gpu/drm/i915/intel_drv.h
View file @ 05394f39
...@@ -127,7 +127,7 @@ intel_mode_get_pixel_multiplier(const struct drm_display_mode *mode) ...@@ -127,7 +127,7 @@ intel_mode_get_pixel_multiplier(const struct drm_display_mode *mode)
struct intel_framebuffer { struct intel_framebuffer {
struct drm_framebuffer base; struct drm_framebuffer base;
struct drm_gem_object *obj; struct drm_i915_gem_object *obj;
}; };
struct intel_fbdev { struct intel_fbdev {
...@@ -166,7 +166,7 @@ struct intel_crtc { ...@@ -166,7 +166,7 @@ struct intel_crtc {
struct intel_unpin_work *unpin_work; struct intel_unpin_work *unpin_work;
int fdi_lanes; int fdi_lanes;
struct drm_gem_object *cursor_bo; struct drm_i915_gem_object *cursor_bo;
uint32_t cursor_addr; uint32_t cursor_addr;
int16_t cursor_x, cursor_y; int16_t cursor_x, cursor_y;
int16_t cursor_width, cursor_height; int16_t cursor_width, cursor_height;
...@@ -220,8 +220,8 @@ intel_get_crtc_for_pipe(struct drm_device *dev, int pipe) ...@@ -220,8 +220,8 @@ intel_get_crtc_for_pipe(struct drm_device *dev, int pipe)
struct intel_unpin_work { struct intel_unpin_work {
struct work_struct work; struct work_struct work;
struct drm_device *dev; struct drm_device *dev;
struct drm_gem_object *old_fb_obj; struct drm_i915_gem_object *old_fb_obj;
struct drm_gem_object *pending_flip_obj; struct drm_i915_gem_object *pending_flip_obj;
struct drm_pending_vblank_event *event; struct drm_pending_vblank_event *event;
int pending; int pending;
bool enable_stall_check; bool enable_stall_check;
...@@ -236,7 +236,8 @@ void intel_dip_infoframe_csum(struct dip_infoframe *avi_if); ...@@ -236,7 +236,8 @@ void intel_dip_infoframe_csum(struct dip_infoframe *avi_if);
extern bool intel_sdvo_init(struct drm_device *dev, int output_device); extern bool intel_sdvo_init(struct drm_device *dev, int output_device);
extern void intel_dvo_init(struct drm_device *dev); extern void intel_dvo_init(struct drm_device *dev);
extern void intel_tv_init(struct drm_device *dev); extern void intel_tv_init(struct drm_device *dev);
extern void intel_mark_busy(struct drm_device *dev, struct drm_gem_object *obj); extern void intel_mark_busy(struct drm_device *dev,
struct drm_i915_gem_object *obj);
extern void intel_lvds_init(struct drm_device *dev); extern void intel_lvds_init(struct drm_device *dev);
extern void intel_dp_init(struct drm_device *dev, int dp_reg); extern void intel_dp_init(struct drm_device *dev, int dp_reg);
void void
...@@ -299,13 +300,13 @@ extern void ironlake_disable_drps(struct drm_device *dev); ...@@ -299,13 +300,13 @@ extern void ironlake_disable_drps(struct drm_device *dev);
extern void intel_init_emon(struct drm_device *dev); extern void intel_init_emon(struct drm_device *dev);
extern int intel_pin_and_fence_fb_obj(struct drm_device *dev, extern int intel_pin_and_fence_fb_obj(struct drm_device *dev,
struct drm_gem_object *obj, struct drm_i915_gem_object *obj,
bool pipelined); bool pipelined);
extern int intel_framebuffer_init(struct drm_device *dev, extern int intel_framebuffer_init(struct drm_device *dev,
struct intel_framebuffer *ifb, struct intel_framebuffer *ifb,
struct drm_mode_fb_cmd *mode_cmd, struct drm_mode_fb_cmd *mode_cmd,
struct drm_gem_object *obj); struct drm_i915_gem_object *obj);
extern int intel_fbdev_init(struct drm_device *dev); extern int intel_fbdev_init(struct drm_device *dev);
extern void intel_fbdev_fini(struct drm_device *dev); extern void intel_fbdev_fini(struct drm_device *dev);
......
drivers/gpu/drm/i915/intel_fb.c
View file @ 05394f39
...@@ -65,8 +65,7 @@ static int intelfb_create(struct intel_fbdev *ifbdev, ...@@ -65,8 +65,7 @@ static int intelfb_create(struct intel_fbdev *ifbdev,
struct fb_info *info; struct fb_info *info;
struct drm_framebuffer *fb; struct drm_framebuffer *fb;
struct drm_mode_fb_cmd mode_cmd; struct drm_mode_fb_cmd mode_cmd;
struct drm_gem_object *fbo = NULL; struct drm_i915_gem_object *obj;
struct drm_i915_gem_object *obj_priv;
struct device *device = &dev->pdev->dev; struct device *device = &dev->pdev->dev;
int size, ret, mmio_bar = IS_GEN2(dev) ? 1 : 0; int size, ret, mmio_bar = IS_GEN2(dev) ? 1 : 0;
...@@ -83,18 +82,17 @@ static int intelfb_create(struct intel_fbdev *ifbdev, ...@@ -83,18 +82,17 @@ static int intelfb_create(struct intel_fbdev *ifbdev,
size = mode_cmd.pitch * mode_cmd.height; size = mode_cmd.pitch * mode_cmd.height;
size = ALIGN(size, PAGE_SIZE); size = ALIGN(size, PAGE_SIZE);
fbo = i915_gem_alloc_object(dev, size); obj = i915_gem_alloc_object(dev, size);
if (!fbo) { if (!obj) {
DRM_ERROR("failed to allocate framebuffer\n"); DRM_ERROR("failed to allocate framebuffer\n");
ret = -ENOMEM; ret = -ENOMEM;
goto out; goto out;
} }
obj_priv = to_intel_bo(fbo);
mutex_lock(&dev->struct_mutex); mutex_lock(&dev->struct_mutex);
/* Flush everything out, we'll be doing GTT only from now on */ /* Flush everything out, we'll be doing GTT only from now on */
ret = intel_pin_and_fence_fb_obj(dev, fbo, false); ret = intel_pin_and_fence_fb_obj(dev, obj, false);
if (ret) { if (ret) {
DRM_ERROR("failed to pin fb: %d\n", ret); DRM_ERROR("failed to pin fb: %d\n", ret);
goto out_unref; goto out_unref;
...@@ -108,7 +106,7 @@ static int intelfb_create(struct intel_fbdev *ifbdev, ...@@ -108,7 +106,7 @@ static int intelfb_create(struct intel_fbdev *ifbdev,
info->par = ifbdev; info->par = ifbdev;
ret = intel_framebuffer_init(dev, &ifbdev->ifb, &mode_cmd, fbo); ret = intel_framebuffer_init(dev, &ifbdev->ifb, &mode_cmd, obj);
if (ret) if (ret)
goto out_unpin; goto out_unpin;
...@@ -134,11 +132,10 @@ static int intelfb_create(struct intel_fbdev *ifbdev, ...@@ -134,11 +132,10 @@ static int intelfb_create(struct intel_fbdev *ifbdev,
else else
info->apertures->ranges[0].size = pci_resource_len(dev->pdev, 0); info->apertures->ranges[0].size = pci_resource_len(dev->pdev, 0);
info->fix.smem_start = dev->mode_config.fb_base + obj_priv->gtt_offset; info->fix.smem_start = dev->mode_config.fb_base + obj->gtt_offset;
info->fix.smem_len = size; info->fix.smem_len = size;
info->screen_base = ioremap_wc(dev->agp->base + obj_priv->gtt_offset, info->screen_base = ioremap_wc(dev->agp->base + obj->gtt_offset, size);
size);
if (!info->screen_base) { if (!info->screen_base) {
ret = -ENOSPC; ret = -ENOSPC;
goto out_unpin; goto out_unpin;
...@@ -168,7 +165,7 @@ static int intelfb_create(struct intel_fbdev *ifbdev, ...@@ -168,7 +165,7 @@ static int intelfb_create(struct intel_fbdev *ifbdev,
DRM_DEBUG_KMS("allocated %dx%d fb: 0x%08x, bo %p\n", DRM_DEBUG_KMS("allocated %dx%d fb: 0x%08x, bo %p\n",
fb->width, fb->height, fb->width, fb->height,
obj_priv->gtt_offset, fbo); obj->gtt_offset, obj);
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
...@@ -176,9 +173,9 @@ static int intelfb_create(struct intel_fbdev *ifbdev, ...@@ -176,9 +173,9 @@ static int intelfb_create(struct intel_fbdev *ifbdev,
return 0; return 0;
out_unpin: out_unpin:
i915_gem_object_unpin(fbo); i915_gem_object_unpin(obj);
out_unref: out_unref:
drm_gem_object_unreference(fbo); drm_gem_object_unreference(&obj->base);
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
out: out:
return ret; return ret;
...@@ -225,7 +222,7 @@ static void intel_fbdev_destroy(struct drm_device *dev, ...@@ -225,7 +222,7 @@ static void intel_fbdev_destroy(struct drm_device *dev,
drm_framebuffer_cleanup(&ifb->base); drm_framebuffer_cleanup(&ifb->base);
if (ifb->obj) { if (ifb->obj) {
drm_gem_object_unreference_unlocked(ifb->obj); drm_gem_object_unreference_unlocked(&ifb->obj->base);
ifb->obj = NULL; ifb->obj = NULL;
} }
} }
......
drivers/gpu/drm/i915/intel_overlay.c
View file @ 05394f39
...@@ -376,24 +376,23 @@ static int intel_overlay_continue(struct intel_overlay *overlay, ...@@ -376,24 +376,23 @@ static int intel_overlay_continue(struct intel_overlay *overlay,
static void intel_overlay_release_old_vid_tail(struct intel_overlay *overlay) static void intel_overlay_release_old_vid_tail(struct intel_overlay *overlay)
{ {
struct drm_gem_object *obj = &overlay->old_vid_bo->base; struct drm_i915_gem_object *obj = overlay->old_vid_bo;
i915_gem_object_unpin(obj); i915_gem_object_unpin(obj);
drm_gem_object_unreference(obj); drm_gem_object_unreference(&obj->base);
overlay->old_vid_bo = NULL; overlay->old_vid_bo = NULL;
} }
static void intel_overlay_off_tail(struct intel_overlay *overlay) static void intel_overlay_off_tail(struct intel_overlay *overlay)
{ {
struct drm_gem_object *obj; struct drm_i915_gem_object *obj = overlay->vid_bo;
/* never have the overlay hw on without showing a frame */ /* never have the overlay hw on without showing a frame */
BUG_ON(!overlay->vid_bo); BUG_ON(!overlay->vid_bo);
obj = &overlay->vid_bo->base;
i915_gem_object_unpin(obj); i915_gem_object_unpin(obj);
drm_gem_object_unreference(obj); drm_gem_object_unreference(&obj->base);
overlay->vid_bo = NULL; overlay->vid_bo = NULL;
overlay->crtc->overlay = NULL; overlay->crtc->overlay = NULL;
...@@ -764,13 +763,12 @@ static u32 overlay_cmd_reg(struct put_image_params *params) ...@@ -764,13 +763,12 @@ static u32 overlay_cmd_reg(struct put_image_params *params)
} }
static int intel_overlay_do_put_image(struct intel_overlay *overlay, static int intel_overlay_do_put_image(struct intel_overlay *overlay,
struct drm_gem_object *new_bo, struct drm_i915_gem_object *new_bo,
struct put_image_params *params) struct put_image_params *params)
{ {
int ret, tmp_width; int ret, tmp_width;
struct overlay_registers *regs; struct overlay_registers *regs;
bool scale_changed = false; bool scale_changed = false;
struct drm_i915_gem_object *bo_priv = to_intel_bo(new_bo);
struct drm_device *dev = overlay->dev; struct drm_device *dev = overlay->dev;
BUG_ON(!mutex_is_locked(&dev->struct_mutex)); BUG_ON(!mutex_is_locked(&dev->struct_mutex));
...@@ -825,7 +823,7 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay, ...@@ -825,7 +823,7 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
regs->SWIDTHSW = calc_swidthsw(overlay->dev, regs->SWIDTHSW = calc_swidthsw(overlay->dev,
params->offset_Y, tmp_width); params->offset_Y, tmp_width);
regs->SHEIGHT = params->src_h; regs->SHEIGHT = params->src_h;
regs->OBUF_0Y = bo_priv->gtt_offset + params-> offset_Y; regs->OBUF_0Y = new_bo->gtt_offset + params-> offset_Y;
regs->OSTRIDE = params->stride_Y; regs->OSTRIDE = params->stride_Y;
if (params->format & I915_OVERLAY_YUV_PLANAR) { if (params->format & I915_OVERLAY_YUV_PLANAR) {
...@@ -839,8 +837,8 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay, ...@@ -839,8 +837,8 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
params->src_w/uv_hscale); params->src_w/uv_hscale);
regs->SWIDTHSW |= max_t(u32, tmp_U, tmp_V) << 16; regs->SWIDTHSW |= max_t(u32, tmp_U, tmp_V) << 16;
regs->SHEIGHT |= (params->src_h/uv_vscale) << 16; regs->SHEIGHT |= (params->src_h/uv_vscale) << 16;
regs->OBUF_0U = bo_priv->gtt_offset + params->offset_U; regs->OBUF_0U = new_bo->gtt_offset + params->offset_U;
regs->OBUF_0V = bo_priv->gtt_offset + params->offset_V; regs->OBUF_0V = new_bo->gtt_offset + params->offset_V;
regs->OSTRIDE |= params->stride_UV << 16; regs->OSTRIDE |= params->stride_UV << 16;
} }
...@@ -857,7 +855,7 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay, ...@@ -857,7 +855,7 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
goto out_unpin; goto out_unpin;
overlay->old_vid_bo = overlay->vid_bo; overlay->old_vid_bo = overlay->vid_bo;
overlay->vid_bo = to_intel_bo(new_bo); overlay->vid_bo = new_bo;
return 0; return 0;
...@@ -970,7 +968,7 @@ static int check_overlay_scaling(struct put_image_params *rec) ...@@ -970,7 +968,7 @@ static int check_overlay_scaling(struct put_image_params *rec)
static int check_overlay_src(struct drm_device *dev, static int check_overlay_src(struct drm_device *dev,
struct drm_intel_overlay_put_image *rec, struct drm_intel_overlay_put_image *rec,
struct drm_gem_object *new_bo) struct drm_i915_gem_object *new_bo)
{ {
int uv_hscale = uv_hsubsampling(rec->flags); int uv_hscale = uv_hsubsampling(rec->flags);
int uv_vscale = uv_vsubsampling(rec->flags); int uv_vscale = uv_vsubsampling(rec->flags);
...@@ -1055,7 +1053,7 @@ static int check_overlay_src(struct drm_device *dev, ...@@ -1055,7 +1053,7 @@ static int check_overlay_src(struct drm_device *dev,
return -EINVAL; return -EINVAL;
tmp = rec->stride_Y*rec->src_height; tmp = rec->stride_Y*rec->src_height;
if (rec->offset_Y + tmp > new_bo->size) if (rec->offset_Y + tmp > new_bo->base.size)
return -EINVAL; return -EINVAL;
break; break;
...@@ -1066,12 +1064,12 @@ static int check_overlay_src(struct drm_device *dev, ...@@ -1066,12 +1064,12 @@ static int check_overlay_src(struct drm_device *dev,
return -EINVAL; return -EINVAL;
tmp = rec->stride_Y * rec->src_height; tmp = rec->stride_Y * rec->src_height;
if (rec->offset_Y + tmp > new_bo->size) if (rec->offset_Y + tmp > new_bo->base.size)
return -EINVAL; return -EINVAL;
tmp = rec->stride_UV * (rec->src_height / uv_vscale); tmp = rec->stride_UV * (rec->src_height / uv_vscale);
if (rec->offset_U + tmp > new_bo->size || if (rec->offset_U + tmp > new_bo->base.size ||
rec->offset_V + tmp > new_bo->size) rec->offset_V + tmp > new_bo->base.size)
return -EINVAL; return -EINVAL;
break; break;
} }
...@@ -1114,7 +1112,7 @@ int intel_overlay_put_image(struct drm_device *dev, void *data, ...@@ -1114,7 +1112,7 @@ int intel_overlay_put_image(struct drm_device *dev, void *data,
struct intel_overlay *overlay; struct intel_overlay *overlay;
struct drm_mode_object *drmmode_obj; struct drm_mode_object *drmmode_obj;
struct intel_crtc *crtc; struct intel_crtc *crtc;
struct drm_gem_object *new_bo; struct drm_i915_gem_object *new_bo;
struct put_image_params *params; struct put_image_params *params;
int ret; int ret;
...@@ -1153,8 +1151,8 @@ int intel_overlay_put_image(struct drm_device *dev, void *data, ...@@ -1153,8 +1151,8 @@ int intel_overlay_put_image(struct drm_device *dev, void *data,
} }
crtc = to_intel_crtc(obj_to_crtc(drmmode_obj)); crtc = to_intel_crtc(obj_to_crtc(drmmode_obj));
new_bo = drm_gem_object_lookup(dev, file_priv, new_bo = to_intel_bo(drm_gem_object_lookup(dev, file_priv,
put_image_rec->bo_handle); put_image_rec->bo_handle));
if (!new_bo) { if (!new_bo) {
ret = -ENOENT; ret = -ENOENT;
goto out_free; goto out_free;
...@@ -1245,7 +1243,7 @@ int intel_overlay_put_image(struct drm_device *dev, void *data, ...@@ -1245,7 +1243,7 @@ int intel_overlay_put_image(struct drm_device *dev, void *data,
out_unlock: out_unlock:
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
mutex_unlock(&dev->mode_config.mutex); mutex_unlock(&dev->mode_config.mutex);
drm_gem_object_unreference_unlocked(new_bo); drm_gem_object_unreference_unlocked(&new_bo->base);
out_free: out_free:
kfree(params); kfree(params);
...@@ -1398,7 +1396,7 @@ void intel_setup_overlay(struct drm_device *dev) ...@@ -1398,7 +1396,7 @@ void intel_setup_overlay(struct drm_device *dev)
{ {
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct intel_overlay *overlay; struct intel_overlay *overlay;
struct drm_gem_object *reg_bo; struct drm_i915_gem_object *reg_bo;
struct overlay_registers *regs; struct overlay_registers *regs;
int ret; int ret;
...@@ -1413,7 +1411,7 @@ void intel_setup_overlay(struct drm_device *dev) ...@@ -1413,7 +1411,7 @@ void intel_setup_overlay(struct drm_device *dev)
reg_bo = i915_gem_alloc_object(dev, PAGE_SIZE); reg_bo = i915_gem_alloc_object(dev, PAGE_SIZE);
if (!reg_bo) if (!reg_bo)
goto out_free; goto out_free;
overlay->reg_bo = to_intel_bo(reg_bo); overlay->reg_bo = reg_bo;
if (OVERLAY_NEEDS_PHYSICAL(dev)) { if (OVERLAY_NEEDS_PHYSICAL(dev)) {
ret = i915_gem_attach_phys_object(dev, reg_bo, ret = i915_gem_attach_phys_object(dev, reg_bo,
...@@ -1423,14 +1421,14 @@ void intel_setup_overlay(struct drm_device *dev) ...@@ -1423,14 +1421,14 @@ void intel_setup_overlay(struct drm_device *dev)
DRM_ERROR("failed to attach phys overlay regs\n"); DRM_ERROR("failed to attach phys overlay regs\n");
goto out_free_bo; goto out_free_bo;
} }
overlay->flip_addr = overlay->reg_bo->phys_obj->handle->busaddr; overlay->flip_addr = reg_bo->phys_obj->handle->busaddr;
} else { } else {
ret = i915_gem_object_pin(reg_bo, PAGE_SIZE, true); ret = i915_gem_object_pin(reg_bo, PAGE_SIZE, true);
if (ret) { if (ret) {
DRM_ERROR("failed to pin overlay register bo\n"); DRM_ERROR("failed to pin overlay register bo\n");
goto out_free_bo; goto out_free_bo;
} }
overlay->flip_addr = overlay->reg_bo->gtt_offset; overlay->flip_addr = reg_bo->gtt_offset;
ret = i915_gem_object_set_to_gtt_domain(reg_bo, true); ret = i915_gem_object_set_to_gtt_domain(reg_bo, true);
if (ret) { if (ret) {
...@@ -1462,7 +1460,7 @@ void intel_setup_overlay(struct drm_device *dev) ...@@ -1462,7 +1460,7 @@ void intel_setup_overlay(struct drm_device *dev)
out_unpin_bo: out_unpin_bo:
i915_gem_object_unpin(reg_bo); i915_gem_object_unpin(reg_bo);
out_free_bo: out_free_bo:
drm_gem_object_unreference(reg_bo); drm_gem_object_unreference(&reg_bo->base);
out_free: out_free:
kfree(overlay); kfree(overlay);
return; return;
......
drivers/gpu/drm/i915/intel_ringbuffer.c
View file @ 05394f39
...@@ -139,7 +139,7 @@ u32 intel_ring_get_active_head(struct intel_ring_buffer *ring) ...@@ -139,7 +139,7 @@ u32 intel_ring_get_active_head(struct intel_ring_buffer *ring)
static int init_ring_common(struct intel_ring_buffer *ring) static int init_ring_common(struct intel_ring_buffer *ring)
{ {
drm_i915_private_t *dev_priv = ring->dev->dev_private; drm_i915_private_t *dev_priv = ring->dev->dev_private;
struct drm_i915_gem_object *obj_priv = to_intel_bo(ring->gem_object); struct drm_i915_gem_object *obj = ring->obj;
u32 head; u32 head;
/* Stop the ring if it's running. */ /* Stop the ring if it's running. */
...@@ -148,7 +148,7 @@ static int init_ring_common(struct intel_ring_buffer *ring) ...@@ -148,7 +148,7 @@ static int init_ring_common(struct intel_ring_buffer *ring)
ring->write_tail(ring, 0); ring->write_tail(ring, 0);
/* Initialize the ring. */ /* Initialize the ring. */
I915_WRITE_START(ring, obj_priv->gtt_offset); I915_WRITE_START(ring, obj->gtt_offset);
head = I915_READ_HEAD(ring) & HEAD_ADDR; head = I915_READ_HEAD(ring) & HEAD_ADDR;
/* G45 ring initialization fails to reset head to zero */ /* G45 ring initialization fails to reset head to zero */
...@@ -178,7 +178,7 @@ static int init_ring_common(struct intel_ring_buffer *ring) ...@@ -178,7 +178,7 @@ static int init_ring_common(struct intel_ring_buffer *ring)
/* If the head is still not zero, the ring is dead */ /* If the head is still not zero, the ring is dead */
if ((I915_READ_CTL(ring) & RING_VALID) == 0 || if ((I915_READ_CTL(ring) & RING_VALID) == 0 ||
I915_READ_START(ring) != obj_priv->gtt_offset || I915_READ_START(ring) != obj->gtt_offset ||
(I915_READ_HEAD(ring) & HEAD_ADDR) != 0) { (I915_READ_HEAD(ring) & HEAD_ADDR) != 0) {
DRM_ERROR("%s initialization failed " DRM_ERROR("%s initialization failed "
"ctl %08x head %08x tail %08x start %08x\n", "ctl %08x head %08x tail %08x start %08x\n",
...@@ -514,17 +514,15 @@ render_ring_dispatch_execbuffer(struct intel_ring_buffer *ring, ...@@ -514,17 +514,15 @@ render_ring_dispatch_execbuffer(struct intel_ring_buffer *ring,
static void cleanup_status_page(struct intel_ring_buffer *ring) static void cleanup_status_page(struct intel_ring_buffer *ring)
{ {
drm_i915_private_t *dev_priv = ring->dev->dev_private; drm_i915_private_t *dev_priv = ring->dev->dev_private;
struct drm_gem_object *obj; struct drm_i915_gem_object *obj;
struct drm_i915_gem_object *obj_priv;
obj = ring->status_page.obj; obj = ring->status_page.obj;
if (obj == NULL) if (obj == NULL)
return; return;
obj_priv = to_intel_bo(obj);
kunmap(obj_priv->pages[0]); kunmap(obj->pages[0]);
i915_gem_object_unpin(obj); i915_gem_object_unpin(obj);
drm_gem_object_unreference(obj); drm_gem_object_unreference(&obj->base);
ring->status_page.obj = NULL; ring->status_page.obj = NULL;
memset(&dev_priv->hws_map, 0, sizeof(dev_priv->hws_map)); memset(&dev_priv->hws_map, 0, sizeof(dev_priv->hws_map));
...@@ -534,8 +532,7 @@ static int init_status_page(struct intel_ring_buffer *ring) ...@@ -534,8 +532,7 @@ static int init_status_page(struct intel_ring_buffer *ring)
{ {
struct drm_device *dev = ring->dev; struct drm_device *dev = ring->dev;
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
struct drm_gem_object *obj; struct drm_i915_gem_object *obj;
struct drm_i915_gem_object *obj_priv;
int ret; int ret;
obj = i915_gem_alloc_object(dev, 4096); obj = i915_gem_alloc_object(dev, 4096);
...@@ -544,16 +541,15 @@ static int init_status_page(struct intel_ring_buffer *ring) ...@@ -544,16 +541,15 @@ static int init_status_page(struct intel_ring_buffer *ring)
ret = -ENOMEM; ret = -ENOMEM;
goto err; goto err;
} }
obj_priv = to_intel_bo(obj); obj->agp_type = AGP_USER_CACHED_MEMORY;
obj_priv->agp_type = AGP_USER_CACHED_MEMORY;
ret = i915_gem_object_pin(obj, 4096, true); ret = i915_gem_object_pin(obj, 4096, true);
if (ret != 0) { if (ret != 0) {
goto err_unref; goto err_unref;
} }
ring->status_page.gfx_addr = obj_priv->gtt_offset; ring->status_page.gfx_addr = obj->gtt_offset;
ring->status_page.page_addr = kmap(obj_priv->pages[0]); ring->status_page.page_addr = kmap(obj->pages[0]);
if (ring->status_page.page_addr == NULL) { if (ring->status_page.page_addr == NULL) {
memset(&dev_priv->hws_map, 0, sizeof(dev_priv->hws_map)); memset(&dev_priv->hws_map, 0, sizeof(dev_priv->hws_map));
goto err_unpin; goto err_unpin;
...@@ -570,7 +566,7 @@ static int init_status_page(struct intel_ring_buffer *ring) ...@@ -570,7 +566,7 @@ static int init_status_page(struct intel_ring_buffer *ring)
err_unpin: err_unpin:
i915_gem_object_unpin(obj); i915_gem_object_unpin(obj);
err_unref: err_unref:
drm_gem_object_unreference(obj); drm_gem_object_unreference(&obj->base);
err: err:
return ret; return ret;
} }
...@@ -578,8 +574,7 @@ static int init_status_page(struct intel_ring_buffer *ring) ...@@ -578,8 +574,7 @@ static int init_status_page(struct intel_ring_buffer *ring)
int intel_init_ring_buffer(struct drm_device *dev, int intel_init_ring_buffer(struct drm_device *dev,
struct intel_ring_buffer *ring) struct intel_ring_buffer *ring)
{ {
struct drm_i915_gem_object *obj_priv; struct drm_i915_gem_object *obj;
struct drm_gem_object *obj;
int ret; int ret;
ring->dev = dev; ring->dev = dev;
...@@ -600,15 +595,14 @@ int intel_init_ring_buffer(struct drm_device *dev, ...@@ -600,15 +595,14 @@ int intel_init_ring_buffer(struct drm_device *dev,
goto err_hws; goto err_hws;
} }
ring->gem_object = obj; ring->obj = obj;
ret = i915_gem_object_pin(obj, PAGE_SIZE, true); ret = i915_gem_object_pin(obj, PAGE_SIZE, true);
if (ret) if (ret)
goto err_unref; goto err_unref;
obj_priv = to_intel_bo(obj);
ring->map.size = ring->size; ring->map.size = ring->size;
ring->map.offset = dev->agp->base + obj_priv->gtt_offset; ring->map.offset = dev->agp->base + obj->gtt_offset;
ring->map.type = 0; ring->map.type = 0;
ring->map.flags = 0; ring->map.flags = 0;
ring->map.mtrr = 0; ring->map.mtrr = 0;
...@@ -632,8 +626,8 @@ int intel_init_ring_buffer(struct drm_device *dev, ...@@ -632,8 +626,8 @@ int intel_init_ring_buffer(struct drm_device *dev,
err_unpin: err_unpin:
i915_gem_object_unpin(obj); i915_gem_object_unpin(obj);
err_unref: err_unref:
drm_gem_object_unreference(obj); drm_gem_object_unreference(&obj->base);
ring->gem_object = NULL; ring->obj = NULL;
err_hws: err_hws:
cleanup_status_page(ring); cleanup_status_page(ring);
return ret; return ret;
...@@ -644,7 +638,7 @@ void intel_cleanup_ring_buffer(struct intel_ring_buffer *ring) ...@@ -644,7 +638,7 @@ void intel_cleanup_ring_buffer(struct intel_ring_buffer *ring)
struct drm_i915_private *dev_priv; struct drm_i915_private *dev_priv;
int ret; int ret;
if (ring->gem_object == NULL) if (ring->obj == NULL)
return; return;
/* Disable the ring buffer. The ring must be idle at this point */ /* Disable the ring buffer. The ring must be idle at this point */
...@@ -654,9 +648,9 @@ void intel_cleanup_ring_buffer(struct intel_ring_buffer *ring) ...@@ -654,9 +648,9 @@ void intel_cleanup_ring_buffer(struct intel_ring_buffer *ring)
drm_core_ioremapfree(&ring->map, ring->dev); drm_core_ioremapfree(&ring->map, ring->dev);
i915_gem_object_unpin(ring->gem_object); i915_gem_object_unpin(ring->obj);
drm_gem_object_unreference(ring->gem_object); drm_gem_object_unreference(&ring->obj->base);
ring->gem_object = NULL; ring->obj = NULL;
if (ring->cleanup) if (ring->cleanup)
ring->cleanup(ring); ring->cleanup(ring);
...@@ -902,11 +896,11 @@ static int blt_ring_init(struct intel_ring_buffer *ring) ...@@ -902,11 +896,11 @@ static int blt_ring_init(struct intel_ring_buffer *ring)
u32 *ptr; u32 *ptr;
int ret; int ret;
obj = to_intel_bo(i915_gem_alloc_object(ring->dev, 4096)); obj = i915_gem_alloc_object(ring->dev, 4096);
if (obj == NULL) if (obj == NULL)
return -ENOMEM; return -ENOMEM;
ret = i915_gem_object_pin(&obj->base, 4096, true); ret = i915_gem_object_pin(obj, 4096, true);
if (ret) { if (ret) {
drm_gem_object_unreference(&obj->base); drm_gem_object_unreference(&obj->base);
return ret; return ret;
...@@ -917,9 +911,9 @@ static int blt_ring_init(struct intel_ring_buffer *ring) ...@@ -917,9 +911,9 @@ static int blt_ring_init(struct intel_ring_buffer *ring)
*ptr++ = MI_NOOP; *ptr++ = MI_NOOP;
kunmap(obj->pages[0]); kunmap(obj->pages[0]);
ret = i915_gem_object_set_to_gtt_domain(&obj->base, false); ret = i915_gem_object_set_to_gtt_domain(obj, false);
if (ret) { if (ret) {
i915_gem_object_unpin(&obj->base); i915_gem_object_unpin(obj);
drm_gem_object_unreference(&obj->base); drm_gem_object_unreference(&obj->base);
return ret; return ret;
} }
......
drivers/gpu/drm/i915/intel_ringbuffer.h
View file @ 05394f39
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
struct intel_hw_status_page { struct intel_hw_status_page {
u32 __iomem *page_addr; u32 __iomem *page_addr;
unsigned int gfx_addr; unsigned int gfx_addr;
struct drm_gem_object *obj; struct drm_i915_gem_object *obj;
}; };
#define I915_RING_READ(reg) i915_safe_read(dev_priv, reg) #define I915_RING_READ(reg) i915_safe_read(dev_priv, reg)
...@@ -32,7 +32,7 @@ struct intel_ring_buffer { ...@@ -32,7 +32,7 @@ struct intel_ring_buffer {
u32 mmio_base; u32 mmio_base;
void *virtual_start; void *virtual_start;
struct drm_device *dev; struct drm_device *dev;
struct drm_gem_object *gem_object; struct drm_i915_gem_object *obj;
unsigned int head; unsigned int head;
unsigned int tail; unsigned int tail;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7