Commit 05572271 authored by Hoang Le's avatar Hoang Le Committed by David S. Miller

tipc: fix uninitialized value for broadcast retransmission

When sending broadcast message on high load system, there are a lot of
unnecessary packets restranmission. That issue was caused by missing in
initial criteria for retransmission.

To prevent this happen, just initialize this criteria for retransmission
in next 10 milliseconds.

Fixes: 31c4f4cc ("tipc: improve broadcast retransmission algorithm")
Acked-by: default avatarYing Xue <ying.xue@windriver.com>
Acked-by: default avatarJon Maloy <jon.maloy@ericsson.com>
Signed-off-by: default avatarHoang Le <hoang.h.le@dektech.com.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 013dc9d5
...@@ -967,6 +967,10 @@ int tipc_link_xmit(struct tipc_link *l, struct sk_buff_head *list, ...@@ -967,6 +967,10 @@ int tipc_link_xmit(struct tipc_link *l, struct sk_buff_head *list,
} }
__skb_dequeue(list); __skb_dequeue(list);
__skb_queue_tail(transmq, skb); __skb_queue_tail(transmq, skb);
/* next retransmit attempt */
if (link_is_bc_sndlink(l))
TIPC_SKB_CB(skb)->nxt_retr =
jiffies + TIPC_BC_RETR_LIM;
__skb_queue_tail(xmitq, _skb); __skb_queue_tail(xmitq, _skb);
TIPC_SKB_CB(skb)->ackers = l->ackers; TIPC_SKB_CB(skb)->ackers = l->ackers;
l->rcv_unacked = 0; l->rcv_unacked = 0;
...@@ -1014,6 +1018,10 @@ static void tipc_link_advance_backlog(struct tipc_link *l, ...@@ -1014,6 +1018,10 @@ static void tipc_link_advance_backlog(struct tipc_link *l,
hdr = buf_msg(skb); hdr = buf_msg(skb);
l->backlog[msg_importance(hdr)].len--; l->backlog[msg_importance(hdr)].len--;
__skb_queue_tail(&l->transmq, skb); __skb_queue_tail(&l->transmq, skb);
/* next retransmit attempt */
if (link_is_bc_sndlink(l))
TIPC_SKB_CB(skb)->nxt_retr = jiffies + TIPC_BC_RETR_LIM;
__skb_queue_tail(xmitq, _skb); __skb_queue_tail(xmitq, _skb);
TIPC_SKB_CB(skb)->ackers = l->ackers; TIPC_SKB_CB(skb)->ackers = l->ackers;
msg_set_seqno(hdr, seqno); msg_set_seqno(hdr, seqno);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment