Commit 05a70a40 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mauro Carvalho Chehab

[media] exynos4-is: Correct clock properties description at the DT binding documentation

The 'camera' DT node needs to have sclk_cam0/1 and pxl_async0/1 clocks
specified, while 'fimc' nodes should have only "fimc" and "sclk_fimc".
"mux" and "parent" are leftovers from early versions of patches adding
DT support, when the IP bus clock parent clock was being set by the
driver. A better solution is needed to have e.g. clocks driver setting
all required parent clocks, before clock consumers start using the
clocks. Currently this binding doesn't describe parent clocks setup,
it needs to be specified and handled somewhere else.
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent b3d8b559
...@@ -17,9 +17,9 @@ Required properties: ...@@ -17,9 +17,9 @@ Required properties:
- compatible : must be "samsung,fimc", "simple-bus" - compatible : must be "samsung,fimc", "simple-bus"
- clocks : list of clock specifiers, corresponding to entries in - clocks : list of clock specifiers, corresponding to entries in
clock-names property; the clock-names property;
- clock-names : must contain "fimc", "sclk_fimc" entries, matching entries - clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0",
in the clocks property. "pxl_async1" entries, matching entries in the clocks property.
The pinctrl bindings defined in ../pinctrl/pinctrl-bindings.txt must be used The pinctrl bindings defined in ../pinctrl/pinctrl-bindings.txt must be used
to define a required pinctrl state named "default" and optional pinctrl states: to define a required pinctrl state named "default" and optional pinctrl states:
...@@ -32,7 +32,6 @@ way around. ...@@ -32,7 +32,6 @@ way around.
The 'camera' node must include at least one 'fimc' child node. The 'camera' node must include at least one 'fimc' child node.
'fimc' device nodes 'fimc' device nodes
------------------- -------------------
...@@ -44,8 +43,7 @@ Required properties: ...@@ -44,8 +43,7 @@ Required properties:
- interrupts: should contain FIMC interrupt; - interrupts: should contain FIMC interrupt;
- clocks: list of clock specifiers, must contain an entry for each required - clocks: list of clock specifiers, must contain an entry for each required
entry in clock-names; entry in clock-names;
- clock-names: must include "fimc", "sclk_fimc", "mux" entries and optionally - clock-names: must contain "fimc", "sclk_fimc" entries.
"parent" entry.
- samsung,pix-limits: an array of maximum supported image sizes in pixels, for - samsung,pix-limits: an array of maximum supported image sizes in pixels, for
details refer to Table 2-1 in the S5PV210 SoC User Manual; The meaning of details refer to Table 2-1 in the S5PV210 SoC User Manual; The meaning of
each cell is as follows: each cell is as follows:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment