Commit 05b8bcc9 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Jonathan Cameron

iio: st_accel: fix iio_triggered_buffer_{pre,post}enable positions

The iio_triggered_buffer_{predisable,postenable} functions attach/detach
the poll functions.

For the predisable hook, the disable code should occur before detaching
the poll func, and for the postenable hook, the poll func should be
attached before the enable code.
Signed-off-by: default avatarAlexandru Ardelean <alexandru.ardelean@analog.com>
Acked-by: default avatarDenis Ciocca <denis.ciocca@st.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 8bb0d36c
...@@ -46,17 +46,19 @@ static int st_accel_buffer_postenable(struct iio_dev *indio_dev) ...@@ -46,17 +46,19 @@ static int st_accel_buffer_postenable(struct iio_dev *indio_dev)
goto allocate_memory_error; goto allocate_memory_error;
} }
err = st_sensors_set_axis_enable(indio_dev, err = iio_triggered_buffer_postenable(indio_dev);
(u8)indio_dev->active_scan_mask[0]);
if (err < 0) if (err < 0)
goto st_accel_buffer_postenable_error; goto st_accel_buffer_postenable_error;
err = iio_triggered_buffer_postenable(indio_dev); err = st_sensors_set_axis_enable(indio_dev,
(u8)indio_dev->active_scan_mask[0]);
if (err < 0) if (err < 0)
goto st_accel_buffer_postenable_error; goto st_sensors_set_axis_enable_error;
return err; return err;
st_sensors_set_axis_enable_error:
iio_triggered_buffer_predisable(indio_dev);
st_accel_buffer_postenable_error: st_accel_buffer_postenable_error:
kfree(adata->buffer_data); kfree(adata->buffer_data);
allocate_memory_error: allocate_memory_error:
...@@ -65,20 +67,22 @@ static int st_accel_buffer_postenable(struct iio_dev *indio_dev) ...@@ -65,20 +67,22 @@ static int st_accel_buffer_postenable(struct iio_dev *indio_dev)
static int st_accel_buffer_predisable(struct iio_dev *indio_dev) static int st_accel_buffer_predisable(struct iio_dev *indio_dev)
{ {
int err; int err, err2;
struct st_sensor_data *adata = iio_priv(indio_dev); struct st_sensor_data *adata = iio_priv(indio_dev);
err = iio_triggered_buffer_predisable(indio_dev);
if (err < 0)
goto st_accel_buffer_predisable_error;
err = st_sensors_set_axis_enable(indio_dev, ST_SENSORS_ENABLE_ALL_AXIS); err = st_sensors_set_axis_enable(indio_dev, ST_SENSORS_ENABLE_ALL_AXIS);
if (err < 0) if (err < 0)
goto st_accel_buffer_predisable_error; goto st_accel_buffer_predisable_error;
err = st_sensors_set_enable(indio_dev, false); err = st_sensors_set_enable(indio_dev, false);
if (err < 0)
goto st_accel_buffer_predisable_error;
st_accel_buffer_predisable_error: st_accel_buffer_predisable_error:
err2 = iio_triggered_buffer_predisable(indio_dev);
if (!err)
err = err2;
kfree(adata->buffer_data); kfree(adata->buffer_data);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment