Commit 05c44565 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde

can: ti_heccn: don't touch skb after netif_rx()

There is no guarantee that the skb is in the same state after calling
net_receive_skb() or netif_rx(). It might be freed or reused. Not really
harmful as its a read access, except you turn on the proper debugging options
which catch a use after free.

Cc: Anant Gole <anantgole@ti.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent a2e78cf7
...@@ -747,9 +747,9 @@ static int ti_hecc_error(struct net_device *ndev, int int_status, ...@@ -747,9 +747,9 @@ static int ti_hecc_error(struct net_device *ndev, int int_status,
} }
} }
netif_rx(skb);
stats->rx_packets++; stats->rx_packets++;
stats->rx_bytes += cf->can_dlc; stats->rx_bytes += cf->can_dlc;
netif_rx(skb);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment