Commit 06344b91 authored by Bob Peterson's avatar Bob Peterson Committed by Steven Whitehouse

GFS2: Eliminate needless parameter from function gfs2_setbit

This patch eliminates parameter "buf1" from function gfs2_setbit.
This is possible because it was always passed in as bi->bi_bh->b_data.
Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent 144a4c2f
...@@ -71,7 +71,6 @@ static u32 rgblk_search(struct gfs2_rgrpd *rgd, u32 goal, ...@@ -71,7 +71,6 @@ static u32 rgblk_search(struct gfs2_rgrpd *rgd, u32 goal,
/** /**
* gfs2_setbit - Set a bit in the bitmaps * gfs2_setbit - Set a bit in the bitmaps
* @rgd: the resource group descriptor * @rgd: the resource group descriptor
* @buf1: the primary buffer that holds the bitmaps
* @buf2: the clone buffer that holds the bitmaps * @buf2: the clone buffer that holds the bitmaps
* @bi: the bitmap structure * @bi: the bitmap structure
* @block: the block to set * @block: the block to set
...@@ -79,16 +78,16 @@ static u32 rgblk_search(struct gfs2_rgrpd *rgd, u32 goal, ...@@ -79,16 +78,16 @@ static u32 rgblk_search(struct gfs2_rgrpd *rgd, u32 goal,
* *
*/ */
static inline void gfs2_setbit(struct gfs2_rgrpd *rgd, unsigned char *buf1, static inline void gfs2_setbit(struct gfs2_rgrpd *rgd, unsigned char *buf2,
unsigned char *buf2, struct gfs2_bitmap *bi, struct gfs2_bitmap *bi, u32 block,
u32 block, unsigned char new_state) unsigned char new_state)
{ {
unsigned char *byte1, *byte2, *end, cur_state; unsigned char *byte1, *byte2, *end, cur_state;
unsigned int buflen = bi->bi_len; unsigned int buflen = bi->bi_len;
const unsigned int bit = (block % GFS2_NBBY) * GFS2_BIT_SIZE; const unsigned int bit = (block % GFS2_NBBY) * GFS2_BIT_SIZE;
byte1 = buf1 + bi->bi_offset + (block / GFS2_NBBY); byte1 = bi->bi_bh->b_data + bi->bi_offset + (block / GFS2_NBBY);
end = buf1 + bi->bi_offset + buflen; end = bi->bi_bh->b_data + bi->bi_offset + buflen;
BUG_ON(byte1 >= end); BUG_ON(byte1 >= end);
...@@ -1369,8 +1368,8 @@ static u64 gfs2_alloc_extent(struct gfs2_rgrpd *rgd, struct gfs2_bitmap *bi, ...@@ -1369,8 +1368,8 @@ static u64 gfs2_alloc_extent(struct gfs2_rgrpd *rgd, struct gfs2_bitmap *bi,
*n = 0; *n = 0;
buffer = bi->bi_bh->b_data + bi->bi_offset; buffer = bi->bi_bh->b_data + bi->bi_offset;
gfs2_trans_add_bh(rgd->rd_gl, bi->bi_bh, 1); gfs2_trans_add_bh(rgd->rd_gl, bi->bi_bh, 1);
gfs2_setbit(rgd, bi->bi_bh->b_data, bi->bi_clone, gfs2_setbit(rgd, bi->bi_clone, bi, blk,
bi, blk, dinode ? GFS2_BLKST_DINODE : GFS2_BLKST_USED); dinode ? GFS2_BLKST_DINODE : GFS2_BLKST_USED);
(*n)++; (*n)++;
goal = blk; goal = blk;
while (*n < elen) { while (*n < elen) {
...@@ -1380,8 +1379,7 @@ static u64 gfs2_alloc_extent(struct gfs2_rgrpd *rgd, struct gfs2_bitmap *bi, ...@@ -1380,8 +1379,7 @@ static u64 gfs2_alloc_extent(struct gfs2_rgrpd *rgd, struct gfs2_bitmap *bi,
if (gfs2_testbit(rgd, buffer, bi->bi_len, goal) != if (gfs2_testbit(rgd, buffer, bi->bi_len, goal) !=
GFS2_BLKST_FREE) GFS2_BLKST_FREE)
break; break;
gfs2_setbit(rgd, bi->bi_bh->b_data, bi->bi_clone, gfs2_setbit(rgd, bi->bi_clone, bi, goal, GFS2_BLKST_USED);
bi, goal, GFS2_BLKST_USED);
(*n)++; (*n)++;
} }
blk = gfs2_bi2rgd_blk(bi, blk); blk = gfs2_bi2rgd_blk(bi, blk);
...@@ -1438,8 +1436,7 @@ static struct gfs2_rgrpd *rgblk_free(struct gfs2_sbd *sdp, u64 bstart, ...@@ -1438,8 +1436,7 @@ static struct gfs2_rgrpd *rgblk_free(struct gfs2_sbd *sdp, u64 bstart,
bi->bi_len); bi->bi_len);
} }
gfs2_trans_add_bh(rgd->rd_gl, bi->bi_bh, 1); gfs2_trans_add_bh(rgd->rd_gl, bi->bi_bh, 1);
gfs2_setbit(rgd, bi->bi_bh->b_data, NULL, gfs2_setbit(rgd, NULL, bi, buf_blk, new_state);
bi, buf_blk, new_state);
} }
return rgd; return rgd;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment