Commit 06b11321 authored by Darrick J. Wong's avatar Darrick J. Wong

xfs: remove inode log format typedef

Remove xfs_inode_log_format_t now that xfs_inode_log_format is
explicitly padded and therefore is a real on-disk structure.  This
enables xfs/122 to check the size of the structure.
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
parent c0664116
...@@ -264,7 +264,7 @@ typedef struct xfs_trans_header { ...@@ -264,7 +264,7 @@ typedef struct xfs_trans_header {
* (if any) is indicated in the ilf_dsize field. Changes to this structure * (if any) is indicated in the ilf_dsize field. Changes to this structure
* must be added on to the end. * must be added on to the end.
*/ */
typedef struct xfs_inode_log_format { struct xfs_inode_log_format {
uint16_t ilf_type; /* inode log item type */ uint16_t ilf_type; /* inode log item type */
uint16_t ilf_size; /* size of this item */ uint16_t ilf_size; /* size of this item */
uint32_t ilf_fields; /* flags for fields logged */ uint32_t ilf_fields; /* flags for fields logged */
...@@ -279,7 +279,7 @@ typedef struct xfs_inode_log_format { ...@@ -279,7 +279,7 @@ typedef struct xfs_inode_log_format {
int64_t ilf_blkno; /* blkno of inode buffer */ int64_t ilf_blkno; /* blkno of inode buffer */
int32_t ilf_len; /* len of inode buffer */ int32_t ilf_len; /* len of inode buffer */
int32_t ilf_boffset; /* off of inode in buffer */ int32_t ilf_boffset; /* off of inode in buffer */
} xfs_inode_log_format_t; };
/* /*
* Old 32 bit systems will log in this format without the 64 bit * Old 32 bit systems will log in this format without the 64 bit
......
...@@ -48,7 +48,7 @@ extern void xfs_iflush_done(struct xfs_buf *, struct xfs_log_item *); ...@@ -48,7 +48,7 @@ extern void xfs_iflush_done(struct xfs_buf *, struct xfs_log_item *);
extern void xfs_istale_done(struct xfs_buf *, struct xfs_log_item *); extern void xfs_istale_done(struct xfs_buf *, struct xfs_log_item *);
extern void xfs_iflush_abort(struct xfs_inode *, bool); extern void xfs_iflush_abort(struct xfs_inode *, bool);
extern int xfs_inode_item_format_convert(xfs_log_iovec_t *, extern int xfs_inode_item_format_convert(xfs_log_iovec_t *,
xfs_inode_log_format_t *); struct xfs_inode_log_format *);
extern struct kmem_zone *xfs_ili_zone; extern struct kmem_zone *xfs_ili_zone;
......
...@@ -2985,7 +2985,7 @@ xlog_recover_inode_pass2( ...@@ -2985,7 +2985,7 @@ xlog_recover_inode_pass2(
struct xlog_recover_item *item, struct xlog_recover_item *item,
xfs_lsn_t current_lsn) xfs_lsn_t current_lsn)
{ {
xfs_inode_log_format_t *in_f; struct xfs_inode_log_format *in_f;
xfs_mount_t *mp = log->l_mp; xfs_mount_t *mp = log->l_mp;
xfs_buf_t *bp; xfs_buf_t *bp;
xfs_dinode_t *dip; xfs_dinode_t *dip;
...@@ -2999,10 +2999,10 @@ xlog_recover_inode_pass2( ...@@ -2999,10 +2999,10 @@ xlog_recover_inode_pass2(
uint isize; uint isize;
int need_free = 0; int need_free = 0;
if (item->ri_buf[0].i_len == sizeof(xfs_inode_log_format_t)) { if (item->ri_buf[0].i_len == sizeof(struct xfs_inode_log_format)) {
in_f = item->ri_buf[0].i_addr; in_f = item->ri_buf[0].i_addr;
} else { } else {
in_f = kmem_alloc(sizeof(xfs_inode_log_format_t), KM_SLEEP); in_f = kmem_alloc(sizeof(struct xfs_inode_log_format), KM_SLEEP);
need_free = 1; need_free = 1;
error = xfs_inode_item_format_convert(&item->ri_buf[0], in_f); error = xfs_inode_item_format_convert(&item->ri_buf[0], in_f);
if (error) if (error)
...@@ -4299,7 +4299,7 @@ xlog_recover_add_to_trans( ...@@ -4299,7 +4299,7 @@ xlog_recover_add_to_trans(
char *dp, char *dp,
int len) int len)
{ {
xfs_inode_log_format_t *in_f; /* any will do */ struct xfs_inode_log_format *in_f; /* any will do */
xlog_recover_item_t *item; xlog_recover_item_t *item;
char *ptr; char *ptr;
...@@ -4333,7 +4333,7 @@ xlog_recover_add_to_trans( ...@@ -4333,7 +4333,7 @@ xlog_recover_add_to_trans(
ptr = kmem_alloc(len, KM_SLEEP); ptr = kmem_alloc(len, KM_SLEEP);
memcpy(ptr, dp, len); memcpy(ptr, dp, len);
in_f = (xfs_inode_log_format_t *)ptr; in_f = (struct xfs_inode_log_format *)ptr;
/* take the tail entry */ /* take the tail entry */
item = list_entry(trans->r_itemq.prev, xlog_recover_item_t, ri_list); item = list_entry(trans->r_itemq.prev, xlog_recover_item_t, ri_list);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment