Commit 06c3bbd3 authored by YueHaibing's avatar YueHaibing Committed by Laurent Pinchart

drm/shmob: Fix return value check in shmob_drm_probe

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 8f1597c8 ("drm: shmobile: Perform initialization/cleanup at probe/remove time")
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
parent 63f8f3ba
...@@ -229,8 +229,8 @@ static int shmob_drm_probe(struct platform_device *pdev) ...@@ -229,8 +229,8 @@ static int shmob_drm_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sdev->mmio = devm_ioremap_resource(&pdev->dev, res); sdev->mmio = devm_ioremap_resource(&pdev->dev, res);
if (sdev->mmio == NULL) if (IS_ERR(sdev->mmio))
return -ENOMEM; return PTR_ERR(sdev->mmio);
ret = shmob_drm_setup_clocks(sdev, pdata->clk_source); ret = shmob_drm_setup_clocks(sdev, pdata->clk_source);
if (ret < 0) if (ret < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment