Commit 06fc46ca authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans Verkuil

media: ge2d: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent cca3af8d
...@@ -1024,7 +1024,7 @@ static int ge2d_probe(struct platform_device *pdev) ...@@ -1024,7 +1024,7 @@ static int ge2d_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int ge2d_remove(struct platform_device *pdev) static void ge2d_remove(struct platform_device *pdev)
{ {
struct meson_ge2d *ge2d = platform_get_drvdata(pdev); struct meson_ge2d *ge2d = platform_get_drvdata(pdev);
...@@ -1032,8 +1032,6 @@ static int ge2d_remove(struct platform_device *pdev) ...@@ -1032,8 +1032,6 @@ static int ge2d_remove(struct platform_device *pdev)
v4l2_m2m_release(ge2d->m2m_dev); v4l2_m2m_release(ge2d->m2m_dev);
v4l2_device_unregister(&ge2d->v4l2_dev); v4l2_device_unregister(&ge2d->v4l2_dev);
clk_disable_unprepare(ge2d->clk); clk_disable_unprepare(ge2d->clk);
return 0;
} }
static const struct of_device_id meson_ge2d_match[] = { static const struct of_device_id meson_ge2d_match[] = {
...@@ -1047,7 +1045,7 @@ MODULE_DEVICE_TABLE(of, meson_ge2d_match); ...@@ -1047,7 +1045,7 @@ MODULE_DEVICE_TABLE(of, meson_ge2d_match);
static struct platform_driver ge2d_drv = { static struct platform_driver ge2d_drv = {
.probe = ge2d_probe, .probe = ge2d_probe,
.remove = ge2d_remove, .remove_new = ge2d_remove,
.driver = { .driver = {
.name = "meson-ge2d", .name = "meson-ge2d",
.of_match_table = meson_ge2d_match, .of_match_table = meson_ge2d_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment