Commit 0724745f authored by Guenter Roeck's avatar Guenter Roeck Committed by Mauro Carvalho Chehab

[media] atmel-isi: Fix bad usage of IS_ERR_VALUE

IS_ERR_VALUE() assumes that its parameter is an unsigned long.
It can not be used to check if an unsigned int reflects an error.
Doing so can result in the following build warning.

drivers/media/platform/soc_camera/atmel-isi.c:
	In function "atmel_isi_probe":
	include/linux/err.h:21:38: warning:
		comparison is always false due to limited range of data type
drivers/media/platform/soc_camera/atmel-isi.c:1089:6: note:
	in expansion of macro "IS_ERR_VALUE"

If that warning is seen, the return value from platform_get_irq() is not
checked for errors.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 1e77d55a
...@@ -1026,7 +1026,7 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi, ...@@ -1026,7 +1026,7 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi,
static int atmel_isi_probe(struct platform_device *pdev) static int atmel_isi_probe(struct platform_device *pdev)
{ {
unsigned int irq; int irq;
struct atmel_isi *isi; struct atmel_isi *isi;
struct resource *regs; struct resource *regs;
int ret, i; int ret, i;
...@@ -1086,7 +1086,7 @@ static int atmel_isi_probe(struct platform_device *pdev) ...@@ -1086,7 +1086,7 @@ static int atmel_isi_probe(struct platform_device *pdev)
isi->width_flags |= 1 << 9; isi->width_flags |= 1 << 9;
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (IS_ERR_VALUE(irq)) { if (irq < 0) {
ret = irq; ret = irq;
goto err_req_irq; goto err_req_irq;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment