Commit 072a7852 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Greg Kroah-Hartman

Input: axp20x-pek - switch to using devm_device_add_group()

Now that we have proper managed API to create device attributes, let's
use it instead of installing a custom devm action.
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 36a44af5
...@@ -182,13 +182,6 @@ static irqreturn_t axp20x_pek_irq(int irq, void *pwr) ...@@ -182,13 +182,6 @@ static irqreturn_t axp20x_pek_irq(int irq, void *pwr)
return IRQ_HANDLED; return IRQ_HANDLED;
} }
static void axp20x_remove_sysfs_group(void *_data)
{
struct device *dev = _data;
sysfs_remove_group(&dev->kobj, &axp20x_attribute_group);
}
static int axp20x_pek_probe_input_device(struct axp20x_pek *axp20x_pek, static int axp20x_pek_probe_input_device(struct axp20x_pek *axp20x_pek,
struct platform_device *pdev) struct platform_device *pdev)
{ {
...@@ -310,22 +303,13 @@ static int axp20x_pek_probe(struct platform_device *pdev) ...@@ -310,22 +303,13 @@ static int axp20x_pek_probe(struct platform_device *pdev)
return error; return error;
} }
error = sysfs_create_group(&pdev->dev.kobj, &axp20x_attribute_group); error = devm_device_add_group(&pdev->dev, &axp20x_attribute_group);
if (error) { if (error) {
dev_err(&pdev->dev, "Failed to create sysfs attributes: %d\n", dev_err(&pdev->dev, "Failed to create sysfs attributes: %d\n",
error); error);
return error; return error;
} }
error = devm_add_action(&pdev->dev,
axp20x_remove_sysfs_group, &pdev->dev);
if (error) {
axp20x_remove_sysfs_group(&pdev->dev);
dev_err(&pdev->dev, "Failed to add sysfs cleanup action: %d\n",
error);
return error;
}
platform_set_drvdata(pdev, axp20x_pek); platform_set_drvdata(pdev, axp20x_pek);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment