Commit 072cb4b1 authored by Lukasz Majewski's avatar Lukasz Majewski Committed by Luis Henriques

thermal: step_wise: fix: Prevent from binary overflow when trend is dropping

commit 26bb0e9a upstream.

It turns out that some boards can have instance->lower greater than 0 and
when thermal trend is dropping it results with next_target equal to -1.

Since the next_target is defined as unsigned long it is interpreted as
0xFFFFFFFF and larger than instance->upper.
As a result the next_target is set to instance->upper which ramps up to
maximal cooling device target when the temperature is steadily decreasing.
Signed-off-by: default avatarLukasz Majewski <l.majewski@samsung.com>
Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
Cc: Mason <slash.tmp@free.fr>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent df008cc8
...@@ -76,7 +76,7 @@ static unsigned long get_target_state(struct thermal_instance *instance, ...@@ -76,7 +76,7 @@ static unsigned long get_target_state(struct thermal_instance *instance,
next_target = instance->upper; next_target = instance->upper;
break; break;
case THERMAL_TREND_DROPPING: case THERMAL_TREND_DROPPING:
if (cur_state == instance->lower) { if (cur_state <= instance->lower) {
if (!throttle) if (!throttle)
next_target = THERMAL_NO_TARGET; next_target = THERMAL_NO_TARGET;
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment