Commit 0732ce21 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman

staging: qlge: fix read of an uninitialized pointer

Currently the pointer 'reporter' is not being initialized and is
being read in a netdev_warn message.  The pointer is not used
and is redundant, fix this by removing it and replacing the reference
to it with priv->reporter instead.

Fixes: 1053c278 ("staging: qlge: coredump via devlink health reporter")
Reviewed-by: default avatarCoiby Xu <coiby.xu@gmail.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Uninitialized pointer read")
Link: https://lore.kernel.org/r/20210203133834.22388-1-colin.king@canonical.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9810cad7
...@@ -150,7 +150,6 @@ static const struct devlink_health_reporter_ops qlge_reporter_ops = { ...@@ -150,7 +150,6 @@ static const struct devlink_health_reporter_ops qlge_reporter_ops = {
void qlge_health_create_reporters(struct qlge_adapter *priv) void qlge_health_create_reporters(struct qlge_adapter *priv)
{ {
struct devlink_health_reporter *reporter;
struct devlink *devlink; struct devlink *devlink;
devlink = priv_to_devlink(priv); devlink = priv_to_devlink(priv);
...@@ -160,5 +159,5 @@ void qlge_health_create_reporters(struct qlge_adapter *priv) ...@@ -160,5 +159,5 @@ void qlge_health_create_reporters(struct qlge_adapter *priv)
if (IS_ERR(priv->reporter)) if (IS_ERR(priv->reporter))
netdev_warn(priv->ndev, netdev_warn(priv->ndev,
"Failed to create reporter, err = %ld\n", "Failed to create reporter, err = %ld\n",
PTR_ERR(reporter)); PTR_ERR(priv->reporter));
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment