Commit 0752e402 authored by Geliang Tang's avatar Geliang Tang Committed by Kees Cook

powerpc/nvram: use memdup_user

Use memdup_user() helper instead of open-coding to simplify the code.
Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent 077090af
...@@ -792,21 +792,17 @@ static ssize_t dev_nvram_write(struct file *file, const char __user *buf, ...@@ -792,21 +792,17 @@ static ssize_t dev_nvram_write(struct file *file, const char __user *buf,
count = min_t(size_t, count, size - *ppos); count = min_t(size_t, count, size - *ppos);
count = min(count, PAGE_SIZE); count = min(count, PAGE_SIZE);
ret = -ENOMEM; tmp = memdup_user(buf, count);
tmp = kmalloc(count, GFP_KERNEL); if (IS_ERR(tmp)) {
if (!tmp) ret = PTR_ERR(tmp);
goto out;
ret = -EFAULT;
if (copy_from_user(tmp, buf, count))
goto out; goto out;
}
ret = ppc_md.nvram_write(tmp, count, ppos); ret = ppc_md.nvram_write(tmp, count, ppos);
out:
kfree(tmp); kfree(tmp);
out:
return ret; return ret;
} }
static long dev_nvram_ioctl(struct file *file, unsigned int cmd, static long dev_nvram_ioctl(struct file *file, unsigned int cmd,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment