Commit 07ffd0d0 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Greg Kroah-Hartman

staging:iio:dac:ad5446: Do not exit powerdown when writing a sample

Both the powerdown mode bits and the sample value are stored in the same
register, so writing a sample while the device is powered down will clear the
power down bits. To avoid this only update the cached value when the device is
powered down.
Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Acked-by: default avatarJonathan Cameron <jic23@kernel.org>

----
v1 actually had a small bug in that it would still write to the device's
register when the sample was updated while the device was powered down. This was
not critical since it would send out the powerdown mode again.
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0f3bcfe6
...@@ -272,7 +272,7 @@ static int ad5446_write_raw(struct iio_dev *indio_dev, ...@@ -272,7 +272,7 @@ static int ad5446_write_raw(struct iio_dev *indio_dev,
long mask) long mask)
{ {
struct ad5446_state *st = iio_priv(indio_dev); struct ad5446_state *st = iio_priv(indio_dev);
int ret; int ret = 0;
switch (mask) { switch (mask) {
case IIO_CHAN_INFO_RAW: case IIO_CHAN_INFO_RAW:
...@@ -282,8 +282,10 @@ static int ad5446_write_raw(struct iio_dev *indio_dev, ...@@ -282,8 +282,10 @@ static int ad5446_write_raw(struct iio_dev *indio_dev,
val <<= chan->scan_type.shift; val <<= chan->scan_type.shift;
mutex_lock(&indio_dev->mlock); mutex_lock(&indio_dev->mlock);
st->cached_val = val; st->cached_val = val;
st->chip_info->store_sample(st, val); if (!st->pwr_down) {
ret = spi_sync(st->spi, &st->msg); st->chip_info->store_sample(st, val);
ret = spi_sync(st->spi, &st->msg);
}
mutex_unlock(&indio_dev->mlock); mutex_unlock(&indio_dev->mlock);
break; break;
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment