Commit 081a8ae2 authored by Colin Ian King's avatar Colin Ian King Committed by Darrick J. Wong

xfs: fix uninitialized error variable

A previous commit removed the initialization of variable 'error' to zero,
and can cause a bogus error return.  This occurs when error contains a
non-zero garbage value and the call to xchk_should_terminate detects a
pending fatal signal and checks for a zero error before setting it
to -EAGAIN. Fix the issue by initializing error to zero.

Fixes: b9454fe0 ("xfs: clean up the inode cluster checking in the inobt scrub")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent 66ae56a5
...@@ -161,7 +161,7 @@ xchk_iallocbt_check_cluster_ifree( ...@@ -161,7 +161,7 @@ xchk_iallocbt_check_cluster_ifree(
bool irec_free; bool irec_free;
bool ino_inuse; bool ino_inuse;
bool freemask_ok; bool freemask_ok;
int error; int error = 0;
if (xchk_should_terminate(bs->sc, &error)) if (xchk_should_terminate(bs->sc, &error))
return error; return error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment