Commit 0849bfec authored by Corey Minyard's avatar Corey Minyard Committed by Linus Torvalds

ipmi: Improve error messages on failed irq enable

When the interrupt enable message returns an error, the messages are
not entirely accurate nor helpful.  So improve them.
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a5f2b3d6
...@@ -663,8 +663,10 @@ static void handle_transaction_done(struct smi_info *smi_info) ...@@ -663,8 +663,10 @@ static void handle_transaction_done(struct smi_info *smi_info)
/* We got the flags from the SMI, now handle them. */ /* We got the flags from the SMI, now handle them. */
smi_info->handlers->get_result(smi_info->si_sm, msg, 4); smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
if (msg[2] != 0) { if (msg[2] != 0) {
dev_warn(smi_info->dev, "Could not enable interrupts" dev_warn(smi_info->dev,
", failed get, using polled mode.\n"); "Couldn't get irq info: %x.\n", msg[2]);
dev_warn(smi_info->dev,
"Maybe ok, but ipmi might run very slowly.\n");
smi_info->si_state = SI_NORMAL; smi_info->si_state = SI_NORMAL;
} else { } else {
msg[0] = (IPMI_NETFN_APP_REQUEST << 2); msg[0] = (IPMI_NETFN_APP_REQUEST << 2);
...@@ -685,10 +687,12 @@ static void handle_transaction_done(struct smi_info *smi_info) ...@@ -685,10 +687,12 @@ static void handle_transaction_done(struct smi_info *smi_info)
/* We got the flags from the SMI, now handle them. */ /* We got the flags from the SMI, now handle them. */
smi_info->handlers->get_result(smi_info->si_sm, msg, 4); smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
if (msg[2] != 0) if (msg[2] != 0) {
dev_warn(smi_info->dev, "Could not enable interrupts" dev_warn(smi_info->dev,
", failed set, using polled mode.\n"); "Couldn't set irq info: %x.\n", msg[2]);
else dev_warn(smi_info->dev,
"Maybe ok, but ipmi might run very slowly.\n");
} else
smi_info->interrupt_disabled = 0; smi_info->interrupt_disabled = 0;
smi_info->si_state = SI_NORMAL; smi_info->si_state = SI_NORMAL;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment