Commit 0890cf6c authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller

switchdev: fix return value of switchdev_port_fdb_dump in case of error

switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is
idx, so we cannot return errval.

Fixes: 45d4122c ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Acked-by: default avatarSridhar Samudrala <sridhar.samudrala@intel.com>
Acked-by: Scott Feldman<sfeldma@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b6588879
...@@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb, ...@@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
.cb = cb, .cb = cb,
.idx = idx, .idx = idx,
}; };
int err;
err = switchdev_port_obj_dump(dev, &dump.obj);
if (err)
return err;
switchdev_port_obj_dump(dev, &dump.obj);
return dump.idx; return dump.idx;
} }
EXPORT_SYMBOL_GPL(switchdev_port_fdb_dump); EXPORT_SYMBOL_GPL(switchdev_port_fdb_dump);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment